From owner-freebsd-current  Wed Mar  6 04:15:58 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id EAA15755
          for current-outgoing; Wed, 6 Mar 1996 04:15:58 -0800 (PST)
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id EAA15750
          for <freebsd-current@FreeBSD.ORG>; Wed, 6 Mar 1996 04:15:55 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by Root.COM (8.6.12/8.6.5) with SMTP id EAA23308; Wed, 6 Mar 1996 04:13:57 -0800
Message-Id: <199603061213.EAA23308@Root.COM>
X-Authentication-Warning: implode.Root.COM: Host localhost didn't use HELO protocol
To: Bruce Evans <bde@zeta.org.au>
cc: jhay@mikom.csir.co.za, freebsd-current@FreeBSD.ORG
Subject: Re: fixes for rename panic (round 1) 
In-reply-to: Your message of "Wed, 06 Mar 1996 18:50:15 +1100."
             <199603060750.SAA09666@godzilla.zeta.org.au> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Wed, 06 Mar 1996 04:13:57 -0800
Sender: owner-current@FreeBSD.ORG
Precedence: bulk

>***************
>*** 953,958 ****
>--- 1005,1012 ----
>  			panic("ufs_rename: lost to startdir");
>  		error = relookup(tdvp, &tvp, tcnp);
>+ 		VREF(tdvp);
>  		if (error)
>  			goto out;
>+ 		vrele(tdvp);
>  		dp = VTOI(tdvp);
>  		xp = NULL;

   It seems like this hunk should be similar to the others - the VREF() should
be before the call to relookup(). Right?

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project