From owner-dev-commits-ports-main@freebsd.org Thu Apr 29 04:10:06 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 863605F5265; Thu, 29 Apr 2021 04:10:06 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FW28Z3RR8z3qbZ; Thu, 29 Apr 2021 04:10:06 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1619669406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YdG0Th5hnOXty8TIuzw4foOwkLGicazCScwjPslo0l0=; b=UMCC4OJ5vrE9qQh6OMJWWE8gcyA7NjN5VNE1Fm+ZN0G3YcPBCJTPTjkq0LGskX6s9PBMry 5l5FXpH/fgBvHyJVkLr5AxWOHwRWay+sSNFv0eisKZRy7iqijVWirAzL71XG+qsAIyBedb j/xAQXZvlDIgapV+WLKiEI1W8cgDax+SLM4rNw35X+hUDpBv47aAenX0/g6mClX0HR3xSJ /fFS8nQwjbz64/7Zwp+UbAOF1mamVX7ZdlYPDnhT5QHmHhhVxB6/oNQmJw9dH1U2/cjXeF Zsowm4HGqzySu9X0NF9jKDYNA/CRldUudIENE/1aGIrAqVmioAq+zyiaYjZA3Q== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 6A08B1C2C9; Thu, 29 Apr 2021 04:10:06 +0000 (UTC) Date: Thu, 29 Apr 2021 04:10:06 +0000 From: Alexey Dokuchaev To: Rene Ladan Cc: Adriaan de Groot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Please use conventional commit messages (Re: git: 2a9b7ca2a362) Message-ID: References: <202104281017.13SAHDF2019723@gitrepo.freebsd.org> <2794032.slGk94SIus@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1619669406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YdG0Th5hnOXty8TIuzw4foOwkLGicazCScwjPslo0l0=; b=gl7PS1NnLSGtp+JWkMDI8szwotvYT70x+/UBVqOjBPpShSpnotk/FrDRzM0pTB6fL4gyY4 62NXsBuqr+NdbGwwi8X2oJ60GiTk+nB/jLkv4RAu9+TTN9clulxSU8ogLg5jExHWXrZiXV L7g+4grN0UOC4v+Gcz7jzrz4Mz735lfs71qdEQMY+uxBz9pHFU5dgOjUll+m02r+eO7Hie 2vFuZYmuDkyo00dj+7+fLztzH1WSTMhYA4ASB3fYR4hwjrHYYL7LGAV7bQXyg1kfUk0iyl BJM/U0BduWQefBeA9DCtoIifrUy1P0fcHrMMvgAUEO6YC8NDOFcIwEoknFXggw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1619669406; a=rsa-sha256; cv=none; b=a40w4YAgZOtq08e2UwQ+qpXbXDUIp93rT+ep1MpL0BlFo9ScjsM2vKjG9nPj916Hg8cZJ7 AuY4zmsbdgTpBCwfYD/8sduz75Z4VCRJwsALBuClr2KGfIwAlkwLoXnTTHUVAGvbWw1Z33 krwyXQrMA3RAcizJ/S+sFpzdq/Pq1598X5mouhLjpXd8lBKcti9nay/zNDOZlZjPXny1O7 xZupwkpC2Nz0cSVff4xcBsU2psaPwfwJdFc9ASvCAvQdaFVAnw0NEPQzsasM/JKScesv74 MJT+oNUH8265gSTcYlAz7HtbUW+qIkKUgEa9Nex9hD4GXSz9YfqYFZ4I4XnOew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 04:10:06 -0000 On Wed, Apr 28, 2021 at 12:44:24PM +0000, Rene Ladan wrote: > On Wed, Apr 28, 2021 at 11:53:46AM +0000, Alexey Dokuchaev wrote: > > On Wed, Apr 28, 2021 at 12:36:39PM +0200, Adriaan de Groot wrote: > > > On Wednesday, 28 April 2021 12:17:13 CEST Alexey Dokuchaev wrote: > > > > commit 2a9b7ca2a3620249bfad050ac3eee6d859926213 > > > > ... > > > > > > > > Update `www/web2ldap' to version 1.5.117. > > > > > > Please use conventional commit messages, [...] Forgot to mention: this "conventional" format of yours adds really a lot of noise to the "git log ." output which in turn makes history harder to study and navigate around. Extra blank lines pessimize it even further. > > I think it is conventional enough. I'd prefer it even better without > > the embedded port name, but I guess I can buy the reasoning why people > > want to see it there. As for its position, I find "foo/bar: blah" > > inconvenient, unnatural, and hard to read. > > This just makes scanning commit mails harder. The problem here is very poor git's default commit email template, and duplicating metainformation that can be automatically inferred from the commit is conceptually wrong. Subject line should contain commit identifier, branch name, and a list of files, directories, or the top directory of the commit. Subversion did this right, FWIW. Take a look at old commit logs in comparison and notice how cleaner and better they were. Li-Wen told me that they are working on improving email template (as it has other deficiencies as well), so let's hope this issue would be fixed at the proper level and people won't have to write idiotic subject-like lines in their commit logs. ./danfe