From owner-freebsd-ports@FreeBSD.ORG Wed Mar 12 06:31:17 2014 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70EFD26A; Wed, 12 Mar 2014 06:31:17 +0000 (UTC) Received: from smtpo.poczta.interia.pl (smtpo.poczta.interia.pl [217.74.65.155]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2E4A5B7D; Wed, 12 Mar 2014 06:31:17 +0000 (UTC) Date: Wed, 12 Mar 2014 07:13:01 +0100 From: vermaden Subject: RE: [patch] sysutils/beadm To: Andrew Hotlab X-Mailer: interia.pl/pf09 In-Reply-To: References: X-Originating-IP: 82.177.252.131 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1394604788; bh=vzgX0TMAUs5i5E9+10D032olcIZD2r0PEMk4soPqc2g=; h=Date:From:Subject:To:Cc:X-Mailer:In-Reply-To:References: X-Originating-IP:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding; b=TqftUkDwe0HcY2OqLDQqlb//ZmfeG7MtyXTygwCu5qBDYfi9DVhmwYaAgaWehnjOX 0yzReZdDhFFXiwYYiV6kajLVAG61lKWf0YW/GZ6EcOKCRFitYMQ4ZlAhLjmmppeyra HqTWMics2OCtyPQyFiF29txugWq7zcJBczT4K39U= Cc: "ports@freebsd.org" , Bryan Drewery X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 06:31:17 -0000 Hi. Merged, along with check if zpool.cache file exists: https://github.com/vermaden/beadm/commit/748d2f2b189581e1cef209f84accd250e3= 5e0954 Regards, vermaden Od: "Andrew Hotlab" Do: "Bryan Drewery" ; "vermaden@interia.pl" ;=20 Wys=C5=82ane: 23:23 Poniedzia=C5=82ek 2014-03-10 Temat: RE: [patch] sysutils/beadm > > Date: Mon, 10 Mar 2014 16:11:16 -0500 > > From: bdrewery@FreeBSD.org > > To: andrew.hotlab@hotmail.com; vermaden@interia.pl > > CC: ports@freebsd.org > > Subject: Re: [patch] sysutils/beadm > > > > On 2014-02-13 16:19, Andrew Hotlab wrote: > >> > >> In my setup I have the following layout (several datasets for /usr, > >> /var, etc.): > >> > >> At this moment the utility does not seems to be able to manage this > >> scheme, since it sets the mountpoint property as "legacy" for all > >> datasets under the root, thus preventing to automatically mount any > >> subdirectory at boot. > >> I've tested this simple solution (to let do the job to the canmount > >> property), and it seems to solve the problem without affecting the > >> behavior when all system folders are located under a single root > >> dataset (please see the patch below). I'd be glad if you'll include it > >> in the next port revision. > >> > >> I'm at your disposal for any further detail. > >> > >> Best regards. > >> > >> Andrew > >> > >> > >> --- ./beadm 2014-01-11 17:08:31.112384992 +0100 > >> +++ /usr/local/sbin/beadm 2014-01-11 17:06:38.620706860 +0100 > >> @@ -505,7 +505,7 @@ > >> if [ ${MOUNT} -eq 0 ] > >> then > >> zfs umount ${POOL}/${BEDS}/${2} > >> - zfs set mountpoint=3Dlegacy ${POOL}/${BEDS}/${2} > >> + zfs set mountpoint=3D/ ${POOL}/${BEDS}/${2} > > > > I've tested this and agree with it. It should be added upstream as it > > makes it simpler to have these extra /mounts. Otherwise you have to > > explicitly set them with mountpoint=3D/usr, /var, instead of inheriting > > from the / dataset. > > The problems I mentioned were probably before we got the 'canmount' > > support in to prevent remounting over /. > > > >> fi > >> fi > >> if ! zpool set bootfs=3D${POOL}/${BEDS}/${2} ${POOL} 1> /dev/null 2> > >> /dev/null > >> @@ -518,6 +518,7 @@ > >> ZFS_LIST=3D$( zfs list -H -o name -r ${POOL}/${BEDS} ) > >> # disable automatic mount on all inactive boot environments > >> echo "${ZFS_LIST}" \ > >> + | grep -v "^${POOL}/${BEDS}$" \ > > > > Note that this change is unrelated. > > > >> | grep -v "^${POOL}/${BEDS}/${2}$" \ > >> | grep -v "^${POOL}/${BEDS}/${2}/" \ > >> | while read NAME > > >=20 > Great! I'm glad to be helpful. I'll look forward to see the change commit= ted to the Ports repository. >=20 > Thank you so much for this wonderful tool! >=20 > Regards. >=20 > Andrew =20 =