Date: Sat, 10 Dec 2011 17:51:21 +0100 From: Robert Millan <rmh@freebsd.org> To: Kirk McKusick <mckusick@mckusick.com> Cc: freebsd-fs@freebsd.org, Adrian Chadd <adrian@freebsd.org> Subject: Re: [PATCH] Wipe other file systems when creating new UFS Message-ID: <CAOfDtXM_gemj%2B1Y-kCNDHKnYGfuuA75TX91veVyUfgS2Q3pWiw@mail.gmail.com> In-Reply-To: <201112091838.pB9IcpUe038205@chez.mckusick.com> References: <20111208134307.GA5266@thorin> <201112091838.pB9IcpUe038205@chez.mckusick.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/12/9 Kirk McKusick <mckusick@mckusick.com>: > Generally speaking, I am in agreement with what you are trying to do. > However, you should not get rid of the check for (and the erasing of) > the UFS1 superblock. By default, UFS2 puts its superblock at an offset > of 64K from the beginning of the partition. You then eraseup to 512K > after that point which is reasonable since on a UFS2 filesystem the > first 64K can be used for the bootstrap. However, UFS1 places its > superblock at 8K from the beginning of the partition. You will not > wipe it out if it exists and its existence (if it has not been > overwritten by a bootstrap) can be quite problematic. Hence the > current code that checks for its existence, and only if found its > being wiped out. Thanks for the tip, I'll prepare a new patch that includes this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXM_gemj%2B1Y-kCNDHKnYGfuuA75TX91veVyUfgS2Q3pWiw>