From nobody Tue Aug 1 02:04:39 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RFJMd0lf1z4pgtN; Tue, 1 Aug 2023 02:04:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RFJMX6sFhz44XV; Tue, 1 Aug 2023 02:04:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690855481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/ENkDvyJA6wAoSt3WR1jatcHDJoMEjn/tTnp0B5qOA8=; b=wEV/GLqL1ZMcWl+yy2otEHJkE6Yi6YVQVbzr9jFp7P+Q2Mj6J3sYBVOtm/iv3kF5jR32kR HlmHl2h8uxc7MaAZAU7IEOvFTdjVthYiRpOd1aKK9IgTHceNMkin9bticAduP3VvFqoL/N dleMKr8klOplQGLktNMAJiQdra67ouPqj3MLT0kaBqBvogdj6L7Gc6BrOwilLzr8If4LUG uV8KVMrYBF8b9kPt8H4oBoCuCbuOA8HxySWLplXWUUdK5BerbxqqLHQ749ZL2nqS/jB0hD IFWLULt80hdjkyu8TmDv4JSu0f2cTS6nfsImOdNIZVDckQ6JdMYKcIMEvPZbow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690855481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/ENkDvyJA6wAoSt3WR1jatcHDJoMEjn/tTnp0B5qOA8=; b=whaqC3RW0K4d6GFejvCbSY1fH0GvewMG77RaCqNhUMbW7uIuo/eapgQHeMmE/X3ixBkZ7y JM7bBrDl6MLQHDV15M4oJUqUFZ3EyhYLcuSHZfT+0w1efPuQTph35rrUgqZL2EzU02ZIIL mpfDmRUGw8Vm7FJJpESWQSkpOyoWg6iM35oa6F37MkbJUQui9XRbSWlA3NeR/hPB/Kirsm jbGfFb/dbsRhyM5kEDTAHJnycPSoD+165iA/LpV00LOtyUfiPyiFWP8tFhnLYtWp191+lF rnm9Y5lZ0YrgXXehau9s0k0HNbmMRcgIxcvZE/xc3OPGpdkI1PZAfhLZT5E/VQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690855481; a=rsa-sha256; cv=none; b=L716C4sJktmAQDAcRmyBwpvBDtgfjXLzkOhSoEoJ9b7N+AOKaq10pgj3JFxG0Z35oBwgah OJ/ynGinSWh76FXnK4xmE0rRAhy2EyjJFei8wMMk0lNIPEC1rwK5hi7ktcmIAO6uT+mCJD uL/Yfq4g7Xxe8ycx3BxsPc0rykhDkNGTrl5TMcUVlgY1TWeXubH+1JwgC3AI+xlPvG5FE7 OKv0laFVAFovWuq5Q57A9AHqsMYP2buYw3EeuNpZZuCtcWgd5er83KhjqBKHw9wOEsXkeO elqb9F4kRiM3U9cYv2CdKwfAJ+oRzEbE10rr/g/HI3/BSUzRndfFouukuNSDEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RFJMX4KzKzKQy; Tue, 1 Aug 2023 02:04:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37124dRD023440; Tue, 1 Aug 2023 02:04:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37124dt1023439; Tue, 1 Aug 2023 02:04:39 GMT (envelope-from git) Date: Tue, 1 Aug 2023 02:04:39 GMT Message-Id: <202308010204.37124dt1023439@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: c2cbd7ffa71a - main - isa_common: find next bit faster List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c2cbd7ffa71a4009e4cc38c04c726ea562b11361 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=c2cbd7ffa71a4009e4cc38c04c726ea562b11361 commit c2cbd7ffa71a4009e4cc38c04c726ea562b11361 Author: Doug Moore AuthorDate: 2023-08-01 02:02:56 +0000 Commit: Doug Moore CommitDate: 2023-08-01 02:02:56 +0000 isa_common: find next bit faster Since ffs is no longer implemented with a linear search, find_next_bit can work in constant time, with masking. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D41251 --- sys/isa/isa_common.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/isa/isa_common.c b/sys/isa/isa_common.c index ca7fd15442b2..994288886cea 100644 --- a/sys/isa/isa_common.c +++ b/sys/isa/isa_common.c @@ -275,12 +275,7 @@ find_first_bit(uint32_t mask) static int find_next_bit(uint32_t mask, int bit) { - bit++; - while (bit < 32 && !(mask & (1 << bit))) - bit++; - if (bit != 32) - return (bit); - return (-1); + return (find_first_bit(mask & (-2 << bit))); } /*