From owner-svn-ports-all@FreeBSD.ORG Wed Mar 26 22:46:00 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2467EE4; Wed, 26 Mar 2014 22:46:00 +0000 (UTC) Received: from mail-yk0-x22b.google.com (mail-yk0-x22b.google.com [IPv6:2607:f8b0:4002:c07::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6505A85B; Wed, 26 Mar 2014 22:46:00 +0000 (UTC) Received: by mail-yk0-f171.google.com with SMTP id q9so1434615ykb.16 for ; Wed, 26 Mar 2014 15:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=u78tQK0Lf/QSM6VMHIhbLvxfSIYNWDxcVUYVDItEimY=; b=je2sWmgW9m1/TZdIVmOFdBgwU9tzExmO8IsM59CZCEwdE8zLfdhMy/PFBkuA+Gwm9X ed0asCyutQ4hr+DNqqSYxOghb3ZyPUAKqD3ekfzx3X+P9C59VHe0OP5BFC4IYuAJ6cr1 m4G4P9HwHFETzWxi5Dcqp3ltgPWRJB99IYWwtkPYm4D7y2ZA7PJVg3GkP0RTxd0754rx BAYNs5rGqlckFPbQSPgg6bRbTjV/CoBDfZyfUEw887TXVFBJhdBFm0EYcJY/5+eBXb6X CQxIFu/18azsyZm/BgLECjlC/KiUtiOGZO3723H4F/SObXo3EQzvLYUD9u8LSHfErKoe Z3FA== MIME-Version: 1.0 X-Received: by 10.236.35.201 with SMTP id u49mr22126863yha.98.1395873959570; Wed, 26 Mar 2014 15:45:59 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.80.11 with HTTP; Wed, 26 Mar 2014 15:45:59 -0700 (PDT) In-Reply-To: <533357E0.2030108@marino.st> References: <201403262018.s2QKId7b067131@svn.freebsd.org> <533351FC.2020908@marino.st> <533357E0.2030108@marino.st> Date: Wed, 26 Mar 2014 23:45:59 +0100 X-Google-Sender-Auth: Kk9gA3gdG2-2c0WskRxjctySIeU Message-ID: Subject: Re: svn commit: r349288 - head/archivers/ocaml-bz2 From: Antoine Brodin To: John Marino Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2014 22:46:01 -0000 On Wed, Mar 26, 2014 at 11:42 PM, John Marino wrote: > On 3/26/2014 23:26, Antoine Brodin wrote: >> On Wed, Mar 26, 2014 at 11:17 PM, John Marino wrote: >>> On 3/26/2014 21:18, Antoine Brodin wrote: >>>> Author: antoine >>>> Date: Wed Mar 26 20:18:38 2014 >>>> New Revision: 349288 >>>> URL: http://svnweb.freebsd.org/changeset/ports/349288 >>>> QAT: https://qat.redports.org/buildarchive/r349288/ >>>> >>>> Log: >>>> Stage support >>>> >>>> Modified: >>>> head/archivers/ocaml-bz2/Makefile >>>> >>>> Modified: head/archivers/ocaml-bz2/Makefile >>>> ============================================================================== >>>> --- head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:09:29 2014 (r349287) >>>> +++ head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:18:38 2014 (r349288) >>>> @@ -12,10 +12,9 @@ DISTNAME= caml${PORTNAME}-${PORTVERSION} >>>> MAINTAINER= jaapb@kerguelen.org >>>> COMMENT= OCaml library to manipulate bz2 files >>>> >>>> +DESTDIRNAME= DONTUSEIT >>>> GNU_CONFIGURE= yes >>>> USES= gmake >>>> -NO_STAGE= yes >>>> - >>> >>> You left USE_OCAML_LDCONFIG= yes. >>> Won't this create an ldconf file that will get added to plist and will >>> conflict potentially with the real ldconf? >>> >>> USE_OCAML_WASH is also set. Is this knob actually desireable? Why is >>> it needed if it's competing with pkg to remove files? >>> >>> I'm not saying I'm right, I'm just trying to learn this. >> >> >> Hi, >> >> I modifed bsd.ocaml.mk so now USE_OCAML_LDCONFIG doesn't violate >> stagedir anymore. >> >> For USE_OCAML_WASH, I have doubts on its usefulness, maybe it should >> be garbage collected in all the tree. > > Hi Antoine, > I suspect that ldconf modifications have to happen at a post-install > step after the package is extracted. This probably needs rework and > somebody to figure it out. > > If you aren't packaging ldconf, then it's not doing anything (which > means its not conflicting either, but there's no point to it) It adds this to plist: @${ECHO_CMD} "@exec ${ECHO_CMD} "%D/${LIB}" >> %D/${OCAML_LDCONF}" \ @${ECHO_CMD} "@unexec ${SED} -i \"\" -e '/${LIB:S#/#\/#g}/d' %D/${OCAML_LDCONF}" >> ${TMPPLIST} Cheers, Antoine