Date: Thu, 17 Aug 2023 02:59:22 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Jessica Clarke <jrtc27@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: da5432eda807 - main - Remove $FreeBSD$: alt two-line .c pattern Message-ID: <ZN2NCk1uzBXu3uhB@FreeBSD.org> In-Reply-To: <CANCZdfoFgucwiOvVeLdxeVSHiZAmEW%2Bodp9Ri9o2jbxAFUBZWw@mail.gmail.com> References: <202308161757.37GHv2ca059368@gitrepo.freebsd.org> <83CE52EE-11ED-4650-A515-F4CE19345BB9@freebsd.org> <CANCZdfoFgucwiOvVeLdxeVSHiZAmEW%2Bodp9Ri9o2jbxAFUBZWw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 16, 2023 at 12:30:58PM -0600, Warner Losh wrote:
> On Wed, Aug 16, 2023, 12:15 PM Jessica Clarke wrote:
> > On 16 Aug 2023, at 18:57, Warner Losh wrote:
> > > commit da5432eda807c4b7232d030d5157d5b417ea4f52
> > >
> > > Remove $FreeBSD$: alt two-line .c pattern
> > >
> > > Remove /^\s*__RCSID\("\$FreeBSD\$"\);\n\n/
> > > ...
> > > diff --git a/sbin/routed/if.c b/sbin/routed/if.c
> > > index 83d8fe503893..72894942fe05 100644
> > > --- a/sbin/routed/if.c
> > > +++ b/sbin/routed/if.c
> > > @@ -33,9 +33,6 @@
> > >
> > > #include "defs.h"
> > > #include "pathnames.h"
> > > -
> > > -__RCSID("$FreeBSD$");
> > > -
> > > struct ifhead ifnet = LIST_HEAD_INITIALIZER(ifnet); /* all interfaces */
> >
> > Alas these diffs aren't style(9)-compliant.
>
> Fixes welcome. I'm sure there's a hundred errors in the 32k changes
> I made. I tried to catch as many as I could...
I think I've also noticed some triple \n\n\n as well, when #include
<cdefs.h>...__RCSID() were following top comment. On a related note,
can we expect to see $FreeBSD$ back one day, when Git will be replaced
with something which does support keywords properly?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZN2NCk1uzBXu3uhB>