From owner-cvs-all  Mon Dec 31  1:20:59 2001
Delivered-To: cvs-all@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1D72E37B623; Mon, 31 Dec 2001 01:20:41 -0800 (PST)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fBV9ISV43560;
	Mon, 31 Dec 2001 10:18:31 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Jake Burkholder <jake@locore.ca>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 trap.c 
In-Reply-To: Your message of "Sun, 30 Dec 2001 21:10:02 EST."
             <20011230211002.C9752@locore.ca> 
Date: Mon, 31 Dec 2001 10:18:27 +0100
Message-ID: <43558.1009790307@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20011230211002.C9752@locore.ca>, Jake Burkholder writes:
>Apparently, On Sun, Dec 30, 2001 at 11:43:59AM -0800,
>	Poul-Henning Kamp said words to the effect of;
>
>> phk         2001/12/30 11:43:59 PST
>> 
>>   Modified files:
>>     sys/i386/i386        trap.c 
>>   Log:
>>   GC an alternate trap_pfault() which has rotted away behind an "#ifdef notyet"
>>   since 21-Mar-95 .
>>   
>>   Revision  Changes    Path
>>   1.210     +0 -118    src/sys/i386/i386/trap.c
>
>This is the one that should have been used.  The existing one is broken because
>it allows faults on user memory in kernel mode without using copy{in,out} or
>{f,s}uword.  Apparently there is still broken kernel code that expects this to
>work.

Well, whenever it can be used it can be resurrected from the CVS file.

Six years behind "#ifdef notyet" is above quota for any piece of code.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message