From owner-svn-ports-all@freebsd.org  Tue Apr 10 16:57:42 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 337ECF86D2B;
 Tue, 10 Apr 2018 16:57:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D5BCA7F7BF;
 Tue, 10 Apr 2018 16:57:41 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id C6A321777A; Tue, 10 Apr 2018 16:57:41 +0000 (UTC)
Date: Tue, 10 Apr 2018 16:57:41 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org, Li-Wen Hsu <lwhsu@FreeBSD.org>
Subject: Re: svn commit: r466297 - head/benchmarks/sysbench
Message-ID: <20180410165741.GA75594@FreeBSD.org>
References: <201804030946.w339kPuW078627@repo.freebsd.org>
 <20180403114306.tmqawuxi47277fxe@ogg.in.absolight.net>
 <20180403115442.GA9888@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180403115442.GA9888@FreeBSD.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 16:57:42 -0000

On Tue, Apr 03, 2018 at 11:54:42AM +0000, Alexey Dokuchaev wrote:
> On Tue, Apr 03, 2018 at 01:43:06PM +0200, Mathieu Arnold wrote:
> > On Tue, Apr 03, 2018 at 09:46:25AM +0000, Sunpoet Po-Chuan Hsieh wrote:
> > > New Revision: 466297
> > > URL: https://svnweb.freebsd.org/changeset/ports/466297
> > > 
> > > Log:
> > >   Simplify BUILD_DEPENDS: use lightweight vim-console instead of vim
> > >   
> > >   PR:		226847
> > >   Submitted by:	lwhsu
> > 
> > Great, so anyone who already has vim installed and wants to pkg install
> > this will not be able to. :-(
> 
> Shouldn't it not affect packages due to being BUILD_DEPENDS?  But even
> more importantly, maintainers really should start reading changelogs
> for the software they maintain:
> 
>   $ make patch
>   $ grep -R xxd work/sysbench-1.0.13/
>   work/sysbench-1.0.13/ChangeLog:     * remove build dependency on xxd (and vim-minimal package)

So, are we still enjoying needless BUILD_DEPENDS, or ChangeLog and grep(1)
are both wrong (lwhsu@ CC'ed)?

./danfe