From owner-svn-ports-all@FreeBSD.ORG Wed Mar 26 22:49:34 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 286411B7; Wed, 26 Mar 2014 22:49:34 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC99F876; Wed, 26 Mar 2014 22:49:33 +0000 (UTC) Received: from [192.168.0.20] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 2F2D9435C7; Wed, 26 Mar 2014 17:49:13 -0500 (CDT) Message-ID: <53335959.4050802@marino.st> Date: Wed, 26 Mar 2014 23:48:57 +0100 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Antoine Brodin , John Marino Subject: Re: svn commit: r349288 - head/archivers/ocaml-bz2 References: <201403262018.s2QKId7b067131@svn.freebsd.org> <533351FC.2020908@marino.st> <533357E0.2030108@marino.st> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: marino@freebsd.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2014 22:49:34 -0000 On 3/26/2014 23:45, Antoine Brodin wrote: > On Wed, Mar 26, 2014 at 11:42 PM, John Marino wrote: >> On 3/26/2014 23:26, Antoine Brodin wrote: >>> On Wed, Mar 26, 2014 at 11:17 PM, John Marino wrote: >>>> On 3/26/2014 21:18, Antoine Brodin wrote: >>>>> Author: antoine >>>>> Date: Wed Mar 26 20:18:38 2014 >>>>> New Revision: 349288 >>>>> URL: http://svnweb.freebsd.org/changeset/ports/349288 >>>>> QAT: https://qat.redports.org/buildarchive/r349288/ >>>>> >>>>> Log: >>>>> Stage support >>>>> >>>>> Modified: >>>>> head/archivers/ocaml-bz2/Makefile >>>>> >>>>> Modified: head/archivers/ocaml-bz2/Makefile >>>>> ============================================================================== >>>>> --- head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:09:29 2014 (r349287) >>>>> +++ head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:18:38 2014 (r349288) >>>>> @@ -12,10 +12,9 @@ DISTNAME= caml${PORTNAME}-${PORTVERSION} >>>>> MAINTAINER= jaapb@kerguelen.org >>>>> COMMENT= OCaml library to manipulate bz2 files >>>>> >>>>> +DESTDIRNAME= DONTUSEIT >>>>> GNU_CONFIGURE= yes >>>>> USES= gmake >>>>> -NO_STAGE= yes >>>>> - >>>> >>>> You left USE_OCAML_LDCONFIG= yes. >>>> Won't this create an ldconf file that will get added to plist and will >>>> conflict potentially with the real ldconf? >>>> >>>> USE_OCAML_WASH is also set. Is this knob actually desireable? Why is >>>> it needed if it's competing with pkg to remove files? >>>> >>>> I'm not saying I'm right, I'm just trying to learn this. >>> >>> >>> Hi, >>> >>> I modifed bsd.ocaml.mk so now USE_OCAML_LDCONFIG doesn't violate >>> stagedir anymore. >>> >>> For USE_OCAML_WASH, I have doubts on its usefulness, maybe it should >>> be garbage collected in all the tree. >> >> Hi Antoine, >> I suspect that ldconf modifications have to happen at a post-install >> step after the package is extracted. This probably needs rework and >> somebody to figure it out. >> >> If you aren't packaging ldconf, then it's not doing anything (which >> means its not conflicting either, but there's no point to it) > > > It adds this to plist: > @${ECHO_CMD} "@exec ${ECHO_CMD} "%D/${LIB}" >> %D/${OCAML_LDCONF}" \ > @${ECHO_CMD} "@unexec ${SED} -i \"\" -e '/${LIB:S#/#\/#g}/d' > %D/${OCAML_LDCONF}" >> ${TMPPLIST} So I think that must be wrong. There should only be one ldconf file -- it stores information of all the installed libraries. There would not be one per package. I say this as somebody that does not use ocaml or know anything about it though. John