From nobody Thu Jan 15 14:50:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsJ3DBzz6P3y0 for ; Thu, 15 Jan 2026 14:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsQsJ1Xhgz3JP9 for ; Thu, 15 Jan 2026 14:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ajjwinlacYFGWmg+FVPPDmPANmby1DX4t013U1wGV/Q=; b=tjz+7xReLr+GtNjv9Yrf7Z71DQruMFJXBQ8//xsOHJxQrLDabMyYsUNLzoLpd39xC/rj/F ab18VGEvY9dirAWVOMmzF5RGEDAUShhU8xJzjnU5huue86040mM9dSf4M6zPnFEPCo473e w6K2hCJPphbOyjFgUMSi3X1Wgu4vZFMF8QZRhUCFscJt/asZ+vHbILtqk8b7/N1ZKb8MZG odm957gWqRsOPDdcudgLHyQYMdF+OkXaUASWtBOMljfiwK/RDfaxyBIb4+Xbksafgun8z3 kAO01/xppwlkUPe6GZvSQuQIWusDDdlaJikHqeN6GhcDNT07xVbRPCJogFvI2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ajjwinlacYFGWmg+FVPPDmPANmby1DX4t013U1wGV/Q=; b=CCMFpAL65PP1REv/4bL7XY/5RXKkr8ttXL0SamITl2zNqno1fQFxSJPKYTOf80EYOdWj78 +Ts4aRaavaoka68e44iwxXQE+HfUIKOzHtsetqeeAFfxVHhaDv6jNZSdoqp+PiHTaQ5ejS yIsQa//4u/PJbbDoImxNDDSD6rv7tMCnd53awm4IXxDStpER9BR3esKmRlSkEvCnuA59qm Nqm3lUhffdTkdGq34YKUm/9xpcCsd+ydR/Xa4rfTbtBkMMY5q7et8zsM5ZVbz8HljJt+pc HNq5vdXVwuLH9A694QOz29XMZ8Zgvtv3zbcQNdB9esddlSiuoXg8+lv1uNO0WA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768488660; a=rsa-sha256; cv=none; b=TWpDUp7lIJS9n4dBV1IqFMLGoIk6IMHZ1orMdpsyOo1ZrvLKRaiF2WS3m0UDCn/LT5bO4j eMlaNobJsm0qnJmeU5WAbuAVaFkLld7+JPef4haKa0VuI6NKe4IPlIPekvtH2GWcLeNh/v a6VZ+0aCuB8u7/wRdo4DgCAR4rXDWlHhrn6qmqfdH4vxsNAo9dF31+osIdstk+nWKinHV6 i8ScNCLlkStjkPIaBLqRU6g6uqymrlr6g2RKDniswLamGyHKKVdMUfnSUu9i4VkdwUPInZ Hxji2bNV3XuL/TS9uNZ2IdOM71Q7fvzgfr3T9qj9ucESCjrGU83mqEoNH4Gf/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsJ0wn7zYwM for ; Thu, 15 Jan 2026 14:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 231ae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Jan 2026 14:50:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrew Turner Subject: git: 6025e23a8f2f - stable/14 - pci/n1sdp: Disable HotPlug List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6025e23a8f2fca481e31436e3fa7a47fba5306d6 Auto-Submitted: auto-generated Date: Thu, 15 Jan 2026 14:50:55 +0000 Message-Id: <6968fecf.231ae.37cb50e9@gitrepo.freebsd.org> The branch stable/14 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=6025e23a8f2fca481e31436e3fa7a47fba5306d6 commit 6025e23a8f2fca481e31436e3fa7a47fba5306d6 Author: Andrew Turner AuthorDate: 2025-10-17 15:02:19 +0000 Commit: Andrew Turner CommitDate: 2026-01-14 21:14:10 +0000 pci/n1sdp: Disable HotPlug Work around an issue when HotPlug is enabled where pcib3 and pcib5 continuously report the following: pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed ... As a workaround disable HotPlug on the N1SDP as it's unlikely anyone will depend on it. Reviewed by: br Fixes: 1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D53134 (cherry picked from commit edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0) --- sys/dev/pci/controller/pci_n1sdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/dev/pci/controller/pci_n1sdp.c b/sys/dev/pci/controller/pci_n1sdp.c index b6f2b11dea05..4c8c04e6057f 100644 --- a/sys/dev/pci/controller/pci_n1sdp.c +++ b/sys/dev/pci/controller/pci_n1sdp.c @@ -345,6 +345,17 @@ n1sdp_pcie_write_config(device_t dev, u_int bus, u_int slot, bus_space_write_4(t, h, offset & ~3, data); } +static int +n1sdp_pcie_acpi_request_feature(device_t pcib __unused, device_t dev __unused, + enum pci_feature feature __unused) +{ + /* + * HotPlug isn't supported on the N1SDP as it causes an interrupt storm + */ + return (EINVAL); +} + + static device_method_t n1sdp_pcie_acpi_methods[] = { DEVMETHOD(device_probe, n1sdp_pcie_acpi_probe), DEVMETHOD(device_attach, n1sdp_pcie_acpi_attach), @@ -352,6 +363,7 @@ static device_method_t n1sdp_pcie_acpi_methods[] = { /* pcib interface */ DEVMETHOD(pcib_read_config, n1sdp_pcie_read_config), DEVMETHOD(pcib_write_config, n1sdp_pcie_write_config), + DEVMETHOD(pcib_request_feature, n1sdp_pcie_acpi_request_feature), DEVMETHOD_END };