Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Nov 2020 22:07:02 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 251430] ports-mgmt/portlint: "the last line of Makefile has to be .include <bsd.port(.post).mk>" is a bit too strict
Message-ID:  <bug-251430-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251430

            Bug ID: 251430
           Summary: ports-mgmt/portlint: "the last line of Makefile has to
                    be .include <bsd.port(.post).mk>" is a bit too strict
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: gerald@FreeBSD.org
          Assignee: marcus@FreeBSD.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)

In case of emulators/wine portlint -C issues a FATAL error:

  FATAL: Makefile: the last line of Makefile has to be .include
<bsd.port(.post).mk>

This is general correct, however that port's Makefile ends with

  .ifndef WINE_SLAVE_BUILD
  .include <bsd.port.post.mk>
  .endif

I suggest to also allow for .endif as the last line of a Makefile.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-251430-7788>