Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Dec 2015 19:37:14 +1100
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        "Chad J. Milios" <milios@ccsys.com>, freebsd-ports@freebsd.org, freebsd@dns-lab.com
Subject:   Re: dns/knot2 Would much appreciate committer
Message-ID:  <566A8B3A.9040408@FreeBSD.org>
In-Reply-To: <566A89BC.60609@FreeBSD.org>
References:  <2BE0F5AA-39FF-4D88-BEAA-0BFDAA47604C@ccsys.com> <566A89BC.60609@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/12/2015 7:30 PM, Kubilay Kocak wrote:
> On 11/12/2015 2:05 PM, Chad J. Milios wrote:
>> Maintainer seems to have overlooked this PR. Trying again seeking
>> maintainer feedback/approval. Thanks to everyone. Viva la FreeBSD
>>
>> Changes should be pretty cut and dried if any committer would like to
>> take a look. I copied the implementation more or less verbatim from
>> openvpn's rc.d script.
>>
>> Any feedback/issues, I'd be happy to resolve. I'm well versed in
>> Bourne sh.
>>
>> Bug 203931 - [PATCH] dns/knot2 enable multiple instances in rc.d
>> script
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203931
>>
> 
> The rebased attachment was added today, so the current Assignee, has not
> overlooked it.

Apologies Chad, I misunderstood. The maintainer hasn't yet replied, correct.

> Your new attachment requires MAINTAINER approval, prior to it being
> committed.

This is the downside of submitting multiple unrelated changes in a
single issue, particularly part way through committing changes.

Each independent change requires maintainer approval, and resets the
timeout timer

> You have unfortunately put yourself in the maintainer-approval ? value.
> 
> I'll take care of bringing the issue up to date.

I've done this now.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?566A8B3A.9040408>