Date: Wed, 23 Oct 2019 15:07:32 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r515252 - head/x11/cool-retro-term Message-ID: <20191023130732.GA81502@urd.tobik.me> In-Reply-To: <20191023125011.GA89792@FreeBSD.org> References: <201910231211.x9NCBOf2070687@repo.freebsd.org> <20191023124302.GA64150@urd.tobik.me> <20191023125011.GA89792@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 23, 2019 at 12:50:11PM +0000, Alexey Dokuchaev wrote: > On Wed, Oct 23, 2019 at 02:43:02PM +0200, Tobias Kortkamp wrote: > > On Wed, Oct 23, 2019 at 12:11:24PM +0000, Alexey Dokuchaev wrote: > > > New Revision: 515252 > > > URL: https://svnweb.freebsd.org/changeset/ports/515252 > > >=20 > > > Log: > > > - Switch to USES+=3Dcompiler:c++11-lang to unbreak on PowerPC inste= ad > > > of the approach taken in r513793 (Clang was never required for th= is > > > port, any not-so-ancient compiler would suffice) > > > - Sort the values on the USES list; avoid hardcoding version numbers > > > [...] > > > @@ -16,24 +16,15 @@ GH_ACCOUNT=3D Swordfish90 > > > GH_PROJECT=3D qmltermwidget:qtw > > > GH_TAGNAME=3D 0.2.0:qtw > > > [...] > > > post-extract: > > > @${RMDIR} ${WRKSRC}/qmltermwidget > > > - @${LN} -s ../qmltermwidget-0.2.0 ${WRKSRC}/qmltermwidget > > > + @${LN} -s ../qmltermwidget-${GH_TAGNAME_qtw} ${WRKSRC}/qmltermwidget > >=20 > > This is very complicated >=20 > Not true. :) >=20 > > and unnecessary. >=20 > That's true. >=20 > > post-extract should be removed and replaced with > > GH_SUBDIR=3D qmltermwidget:qtw >=20 > Yeah, I know; AFAIR I've ported this before we had multi-repo (external > references) support in the framework and never converted. Sure, but you might as well modernize the port since you are touching it (and post-extract) now. > I can do that if you insist. Yes, I insist. Thank you in advance. --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2wUI9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2G9twf+MNLYCW07LoSMwyKPUN6dUbjPUFWawCv/Zp/5JMSN4hrgvpU1wovEZ04E BdLShRkSX9qgiaIW48w+dlYKdda3S++1Mc99w5KDhksRSOvOUSPC5Vn4Q7fNKPSM b8zL2APyccMI+pBl65EEbzPCw67h2tEJefbkaDvkjYowi+sl1XoavhmN6pq1YXnl Pu7StwTyVsMkbuq1V2LgLlVHpYAz425Eq+E6/I4ap5+qQ6YJDugzrvhRaKK0xhRJ CNg2iFF9LwkgIC+yxLJKRAjpoeNlvH0iXNuDki8lMXIVt1JajJrEOWA28POroNh0 8pm9svxEZob0FoytockiJQHjn/p3rQ== =s4bT -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191023130732.GA81502>