From owner-svn-src-all@FreeBSD.ORG Fri Nov 19 21:46:14 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3379C106564A; Fri, 19 Nov 2010 21:46:14 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 048388FC08; Fri, 19 Nov 2010 21:46:14 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id AEC1A46B23; Fri, 19 Nov 2010 16:46:13 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B405B8A01D; Fri, 19 Nov 2010 16:46:12 -0500 (EST) From: John Baldwin To: Attilio Rao Date: Fri, 19 Nov 2010 16:42:00 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201011191943.oAJJhv3i087205@svn.freebsd.org> <201011191617.51552.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201011191642.00761.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 19 Nov 2010 16:46:12 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215544 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 21:46:14 -0000 On Friday, November 19, 2010 4:27:27 pm Attilio Rao wrote: > 2010/11/19 John Baldwin : > > On Friday, November 19, 2010 2:43:57 pm Attilio Rao wrote: > >> Author: attilio > >> Date: Fri Nov 19 19:43:56 2010 > >> New Revision: 215544 > >> URL: http://svn.freebsd.org/changeset/base/215544 > >> > >> Log: > >> Scan the list in reverse order for the shutdown handlers of loaded modules. > >> This way, when there is a dependency between two modules, the handler of the > >> latter probed runs first. > >> > >> This is a similar approach as the modules are unloaded in the same > >> linkerfile. > >> > >> Sponsored by: Sandvine Incorporated > >> Submitted by: Nima Misaghian > >> MFC after: 1 week > >> > >> Modified: > >> head/sys/kern/kern_module.c > >> > >> Modified: head/sys/kern/kern_module.c > >> ============================================================================== > >> --- head/sys/kern/kern_module.c Fri Nov 19 18:59:35 2010 (r215543) > >> +++ head/sys/kern/kern_module.c Fri Nov 19 19:43:56 2010 (r215544) > >> @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$"); > >> > >> static MALLOC_DEFINE(M_MODULE, "module", "module data structures"); > >> > >> -typedef TAILQ_HEAD(, module) modulelist_t; > >> +typedef TAILQ_HEAD(modulelst, module) modulelist_t; > > > > Is modulelist already taken? If not, we should probably just retire > > 'modulelist_t' and replace it with 'struct modulelist'. > > Note that I used modulelst, not modulelist. > Probabilly, if you think the name may be still confusing, we can > pickup one another further. Yes, I'd much prefer 'modulelist' with the extra 'i' as it is more readable. If you go that route, I think you can drop modulelist_t since style(9) discourages foo_t types unless they are required by a standard. -- John Baldwin