From owner-freebsd-current@FreeBSD.ORG Thu Aug 19 17:53:41 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3154F16A4CE; Thu, 19 Aug 2004 17:53:41 +0000 (GMT) Received: from mail.mcneil.com (rrcs-west-24-199-45-54.biz.rr.com [24.199.45.54]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B0EE43D60; Thu, 19 Aug 2004 17:53:41 +0000 (GMT) (envelope-from sean@mcneil.com) Received: from localhost (localhost.mcneil.com [127.0.0.1]) by mail.mcneil.com (Postfix) with ESMTP id A924FFD026; Thu, 19 Aug 2004 10:53:40 -0700 (PDT) Received: from mail.mcneil.com ([127.0.0.1]) by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 51307-01; Thu, 19 Aug 2004 10:53:40 -0700 (PDT) Received: from [24.199.45.54] (mcneil.com [24.199.45.54]) by mail.mcneil.com (Postfix) with ESMTP id 09DBBFD012; Thu, 19 Aug 2004 10:53:40 -0700 (PDT) From: Sean McNeil To: Andre Oppermann In-Reply-To: <4124E1DA.B5341C04@freebsd.org> References: <1092881027.999.3.camel@server.mcneil.com> <412497B5.6040203@freebsd.org> <4124D1D4.5080307@samsco.org> <200408191251.32319.jhb@FreeBSD.org> <4124E1DA.B5341C04@freebsd.org> Content-Type: text/plain Message-Id: <1092938019.79038.4.camel@server.mcneil.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 19 Aug 2004 10:53:39 -0700 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at mcneil.com cc: freebsd-current@FreeBSD.org cc: John Baldwin Subject: kernel module options (was ipfw2 broken) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2004 17:53:41 -0000 On Thu, 2004-08-19 at 10:22, Andre Oppermann wrote: > John Baldwin wrote: > > > > On Thursday 19 August 2004 12:14 pm, Scott Long wrote: > > > Andre Oppermann wrote: > > > > Sean McNeil wrote: > > > >> How do I get the ipfw2 module to compile with divert? It doesn't > > > >> recognize the following in my config file when building the module: > > > >> > > > >> options IPFIREWALL_FORWARD > > > >> options IPDIVERT > > > >> > > > >> Also, the /etc/rc.d/ipfw script is looking for an invalid sysctl var: > > > >> > > > >> net.inet.ip.fw.enable > > > >> > > > >> and it will fail if I have the IPFIREWALL option which compiles the code > > > >> into the kernel because it will try to load and return 1 on a failure. > > > > > > > > I'm looking into it and will have a fix later today. > > > > > > This, and all of the rc.d, module loading, and kernel option problems > > > are now a blocking issue for BETA1. We had planned to start the BETA1 > > > no later than 2200 UTC today. What is your schedule for getting all of > > > this fixed? > > > > It looks like fixing the rc.d script is simply a matter of checking for the fw > > node rather than fw.enable. The pfil(9) requirement is just a matter of > > documenting the new requirement. The IPDIVERT thing is probably larger > > though. :( We may need to just tell people to compile ipfw into the kernel > > for now if they want divert sockets, much as they do if they want 'default to > > accept'. > > IPDIVERT wasn't compiled into the module before. It's surrounded by > #if !defined(KLD_MODULE). However if the kernel was compiled with option > IPDIVERT but w/o IPFIREWALL is was working anyway. Has this changed? From what I saw yesterday no option in my config file could possibly effect the compilation of the ipfw2 module. The only way I could see doing it was to modify the Makefile for the module. yuk. I would like to see a general mechanism supported to turn on various options within a module build. Would it be possible to fix module building to honor options from the config? Cheers, Sean