From nobody Sat May 27 20:58:16 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QTDf90MYGz4Wn1T; Sat, 27 May 2023 20:58:25 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QTDf83Xg7z4Lbb; Sat, 27 May 2023 20:58:24 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 34RKwGJ0052970; Sat, 27 May 2023 23:58:16 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 34RKwGa4052969; Sat, 27 May 2023 23:58:16 +0300 (MSK) (envelope-from dchagin) Date: Sat, 27 May 2023 23:58:16 +0300 From: Dmitry Chagin To: Enji Cooper Cc: Peter Holm , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: acfb06062a68 - main - stress2: Fix warnings Message-ID: References: <202305270835.34R8ZA3g041896@gitrepo.freebsd.org> <41908493-F312-4BA2-A72B-B3C047656CCC@gmail.com> <605A888E-8907-4B20-8922-86511E383377@gmail.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <605A888E-8907-4B20-8922-86511E383377@gmail.com> X-Rspamd-Queue-Id: 4QTDf83Xg7z4Lbb X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, May 27, 2023 at 01:55:23PM -0700, Enji Cooper wrote: > > > On May 27, 2023, at 12:35 PM, Peter Holm wrote: > > > > On Sat, May 27, 2023 at 11:10:23AM -0700, Enji Cooper wrote: > >> > >>> On May 27, 2023, at 1:35 AM, Peter Holm wrote: > >>> > >>> The branch main has been updated by pho: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=acfb06062a6862f7c823242243e68f7bcaf29999 > >>> > >>> commit acfb06062a6862f7c823242243e68f7bcaf29999 > >>> Author: Peter Holm > >>> AuthorDate: 2023-05-27 08:31:00 +0000 > >>> Commit: Peter Holm > >>> CommitDate: 2023-05-27 08:31:00 +0000 > >>> > >>> stress2: Fix warnings > >> > >> It seems like `n` could be removed in all of the sample programs. > >> Cheers, > >> -Enji > >> > > > > Both 'n' and 'm' are used if DEBUG is defined. > > > > [pho@mercat1 /usr/src/tools/test/stress2/misc]$ ./reaper2.sh > > n = 19779 out of 56033 > > n = 20099 out of 56319 > > n = 20121 out of 56406 > > I see. Maybe the variables should only be declared/defined in the DEBUG case? Right now __unused kind of sends the wrong message to the developer and to the compiler (potentially). __diagused > Cheers, > -Enji >