Date: Fri, 27 Jul 2012 06:00:17 +0300 From: Alex Kozlov <ak@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301558 - head/www/volta Message-ID: <20120727030017.GA74963@ravenloft.kiev.ua> In-Reply-To: <20120726185445.GA92687@FreeBSD.org> References: <201207261022.q6QAM7LM066223@svn.freebsd.org> <20120726185445.GA92687@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 26, 2012 at 06:54:45PM +0000, Alexey Dokuchaev wrote: > On Thu, Jul 26, 2012 at 10:22:07AM +0000, Alex Kozlov wrote: > > New Revision: 301558 > > URL: http://svn.freebsd.org/changeset/ports/301558 > > > > --- head/www/volta/pkg-descr Thu Jul 26 10:06:24 2012 (r301557) > > +++ head/www/volta/pkg-descr Thu Jul 26 10:22:06 2012 (r301558) > > @@ -3,7 +3,8 @@ Squid caching proxy server (http://www.s > > can dynamically alter URI requests that pass through Squid based on > > various criteria. > > > > -It uses a state machine to parse URIs and rules, and a constant database > > -to store and access those rules. > > +It uses a state machine to parse URIs and rules, and a constant > > +database to store and access those rules. It can then either perform > > +conditional rewrites internally, or by evaluating Lua scripts. > What was wrong with previous formatting? It perfectly fit 80 (78, 76) chars > per line rule, so it would be nice to know the rationale behind the change. Apologies, I don't know about any hard rules for pkg-plist format, so I assumed that 72 is acceptable and I didn't want to modify the submitted patch unnecessarily. If such rules exist, they should be explicitly added to Porters Handbook (pkg-descr example from it has 69 characters long line) and possibly to portlint. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120727030017.GA74963>