From owner-cvs-doc@FreeBSD.ORG Mon Jul 25 08:03:40 2011 Return-Path: Delivered-To: cvs-doc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 155FC106564A; Mon, 25 Jul 2011 08:03:40 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 62C528FC08; Mon, 25 Jul 2011 08:03:39 +0000 (UTC) Received: from alph.allbsd.org (p3028-ipbf608funabasi.chiba.ocn.ne.jp [125.175.94.28]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.4) with ESMTP id p6P83Pa7011458; Mon, 25 Jul 2011 17:03:35 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id p6P83P5Z077736; Mon, 25 Jul 2011 17:03:25 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 25 Jul 2011 17:03:05 +0900 (JST) Message-Id: <20110725.170305.1112186546386513449.hrs@allbsd.org> To: shaun@FreeBSD.org From: Hiroki Sato In-Reply-To: <20110721125514.GA57642@charon.picobyte.net> References: <201107202352.p6KNqCkN034366@repoman.freebsd.org> <20110721.123130.698363444164784046.hrs@allbsd.org> <20110721125514.GA57642@charon.picobyte.net> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Jul_25_17_03_05_2011_636)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Mon, 25 Jul 2011 17:03:37 +0900 (JST) X-Spam-Status: No, score=-102.3 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT,DIRECTOCNDYN,RCVD_IN_CHINA,RCVD_IN_CHINA_KR, RCVD_IN_RP_RNBL, RCVD_IN_TAIWAN, SPF_SOFTFAIL, USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on gatekeeper.allbsd.org Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: www/en/cgi Makefile www/share/mk web.site.mk X-BeenThere: cvs-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the doc and www trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2011 08:03:40 -0000 ----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Shaun, Shaun Amott wrote in <20110721125514.GA57642@charon.picobyte.net>: sh> On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote: sh> > What do you think about the attached patch? I did not notice these sh> > changes were submitted somewhere for review before the commit... sh> > sh> > -- Hiroki sh> sh> Hi Hiroki, sh> sh> The change was a temporary quick-fix to get the PR viewer working again. sh> I am not intimately familiar with the doc build system, so wasn't sure sh> about the best way to add the new subdirectories; but your way looks a sh> lot cleaner to me. sh> sh> The script itself was made available some time ago on freebsd-www, so I sh> considered it reviewed; I just didn't foresee the need for the other sh> changes. Thank you for your reply. I committed the patch just now and is checking if things go well. I do not think there is a serious problem with your commit, but next time when you have to change our www/doc build infrastructure, please submit a whole patch including that change to -doc@. As you know it is (unnecessarily) complex and breaking the build prevents www.freebsd.org from updating. I and other doc folks are willing to review it. -- Hiroki ----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk4tIzkACgkQTyzT2CeTzy0G5gCgsBvmA0mwUc6WXNbPqc2hbxiy UfQAn186yRrinQUqP1mQ08YFRgG70ivf =LUvA -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)----