From owner-freebsd-hackers@FreeBSD.ORG Fri Feb 4 10:32:13 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 1C8711065672; Fri, 4 Feb 2011 10:32:13 +0000 (UTC) Date: Fri, 4 Feb 2011 10:32:13 +0000 From: Alexander Best To: Eygene Ryabinkin Message-ID: <20110204103213.GA45096@freebsd.org> References: <20110203194306.GA55376@freebsd.org> <20110204102221.GA41464@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: freebsd-hackers@freebsd.org Subject: Re: insufficient flag handling in tools/install.sh X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2011 10:32:13 -0000 On Fri Feb 4 11, Eygene Ryabinkin wrote: > Alexander, good day. > > Fri, Feb 04, 2011 at 10:22:21AM +0000, Alexander Best wrote: > > hi eygene. thanks a lot for your patch. > > You're welcome ;)) > > > i made two changes: > > > > 1) also catch the -v option for install(1). > > Yep. > > > 2) install(1) accepts multiple directories as arguments, when he -d flag has > > been specified. so i don't think it's necessary to iterate through all the > > directories passed to install.sh and invoke install(1) with only one > > argument at a time. > > I had overlooked that, thanks for spotting. > > > could you take a look at the attached patch? > > Looks fine and works for me, thanks! cool. :) any committer volunteering to commit these changes? ;) cheers. alex > -- > Eygene Ryabinkin ,,,^..^,,, > [ Life's unfair - but root password helps! | codelabs.ru ] > [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] -- a13x