From owner-cvs-all Thu Jul 18 8:23:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 162BB37B4AA for ; Thu, 18 Jul 2002 08:22:53 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4369443E6A for ; Thu, 18 Jul 2002 08:22:51 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7664 invoked from network); 18 Jul 2002 15:22:50 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 18 Jul 2002 15:22:50 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g6IFMn061586; Thu, 18 Jul 2002 11:22:49 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020718143939.M7896-100000@gamplex.bde.org> Date: Thu, 18 Jul 2002 11:22:54 -0400 (EDT) From: John Baldwin To: Bruce Evans Subject: RE: cvs commit: src/sys/i386/include atomic.h Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 18-Jul-2002 Bruce Evans wrote: > On Wed, 17 Jul 2002, John Baldwin wrote: > >> On 17-Jul-2002 Mark Murray wrote: >> > markm 2002/07/17 09:19:37 PDT >> > >> > Modified files: >> > sys/i386/include atomic.h >> > Log: >> > Clean up the syntax WRT semicolons at the end of function-like-macros, and protect GCCisms >> > from >> > non-GNU compilers and lint. >> >> I would prefer you use #error instead of non-working dummy functions. > > This file already used #error for that. The purpose of the commit is to > specially break this for lint only. You're right, I was preferring #error for each function though. :) > I would prefer the file to be correctly ifdefed and fall back to extern > functions in cases that can't be implemented inline, much like > . Then it could be compiled by any C compiler. > The kernel just wouldn't link unless the extern functions were actually > implemented somewhere, and might run much slower if they were implemented. This is better than using #error. > Bruce -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message