From owner-svn-src-head@FreeBSD.ORG Sun Jun 7 22:41:49 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31598612; Sun, 7 Jun 2015 22:41:49 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10A3E1BDA; Sun, 7 Jun 2015 22:41:49 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t57MfmtG023215; Sun, 7 Jun 2015 22:41:48 GMT (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 81D4E896B; Sun, 7 Jun 2015 22:41:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id pFZ9ipbXMfQW; Sun, 7 Jun 2015 22:41:45 +0000 (UTC) Message-ID: <5574C8B2.4020700@FreeBSD.org> DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 62D388967 Date: Sun, 07 Jun 2015 17:41:54 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Konstantin Belousov CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284105 - head/bin/cp References: <201506070349.t573ngeh064017@svn.freebsd.org> <20150607140621.GI2499@kib.kiev.ua> In-Reply-To: <20150607140621.GI2499@kib.kiev.ua> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2015 22:41:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/7/2015 9:06 AM, Konstantin Belousov wrote: > On Sun, Jun 07, 2015 at 03:49:42AM +0000, Bryan Drewery wrote: >> Author: bdrewery >> Date: Sun Jun 7 03:49:41 2015 >> New Revision: 284105 >> URL: https://svnweb.freebsd.org/changeset/base/284105 >> >> Log: >> Cleanup some indentation issues. >> >> Modified: >> head/bin/cp/utils.c >> >> Modified: head/bin/cp/utils.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/bin/cp/utils.c Sat Jun 6 22:03:24 2015 (r284104) >> +++ head/bin/cp/utils.c Sun Jun 7 03:49:41 2015 (r284105) >> @@ -122,18 +122,17 @@ copy_file(const FTSENT *entp, int dne) >> /* remove existing destination file name,=20 >> * create a new file */ >> (void)unlink(to.p_path); >> - if (!lflag) >> + if (!lflag) { > It seems that the next two lines are indented in a funny way as well. I fixed the "look" around code I was updating to make my update more clea= r. The whitespace in the lines I updated in this commit is still wrong in many ways. There's several style/whitespace issues in the bin/cp files and I wasn't sure what scope of reindentation would be acceptable to others. If there's no objection I will cleanup all of the bin/cp files. Regards, Bryan Drewery --jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVdMiyAAoJEDXXcbtuRpfPy3EIAMJ+D1uXcLODIdJ/Egsg7L0C MI6uaxlJOeKni6nB7dq+8XXFN3EEwZFTljqgXyr4gBeSBM3Fd4jH4isfzahsoEls KWH6RgR1wYF59zLmNji4jb+7OlwrYGK66DXhKgcSltWfe5oG2Yz4NFnY6pep/DKS CQG9ZteYvMwDotLu4wD4P141EyeRvxpkgXmRIPMTXUCuZ5A5NvxrlhTeWmAGyDqG jltEl4oHeK4jOCtcdnvYirjGiWVXMRbyANg9QK8ZzdWPn3oA3VbykJiS5hQDuTAV TLYO6FLSD/+mr75mGYYUJMEkLVsHJyO6DO9Mr3REz2t+MuRKwNkXAJa9y0arUzc= =7QIT -----END PGP SIGNATURE----- --jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG--