From owner-freebsd-current@FreeBSD.ORG Mon Jun 9 04:55:21 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55D1837B404 for ; Mon, 9 Jun 2003 04:55:21 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 727C743FAF for ; Mon, 9 Jun 2003 04:55:19 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4514 invoked from network); 9 Jun 2003 11:55:18 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 9 Jun 2003 11:55:18 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h59BtHGI004320; Mon, 9 Jun 2003 07:55:17 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030607234641.J81111@znfgre.qbhto.arg> Date: Mon, 09 Jun 2003 07:55:18 -0400 (EDT) From: John Baldwin To: Doug Barton cc: freebsd-current@freebsd.org Subject: RE: cvs commit: src/sys/dev/pci pci.c (fwd) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jun 2003 11:55:21 -0000 On 08-Jun-2003 Doug Barton wrote: > This set of commits seems to have fixed a perennial problem I've had with > my laptop and acpi. Previously, about every 3rd or 4th reboot the pci bus > would fail to initialize, the major symptom of which was that the xl card > wouldn't set up, and I'd have to reboot again. Disabling acpi eliminated > the problem (or the symptom, depending on how you look at it). > > With a kernel built from the latest sources, the pci bus and xl are happy, > but I'm getting flooded with the following: > > ACPI-0340: *** Error: Could not release ACPI Global Lock, AE_BAD_PARAMETER > > This is on an older thinkpad A21e. It has run -current fine for over a > year, modulo this pci problem, and general thinkpad <> acpi unhappiness. > Any other details needed, just ask. This message is due to a bug in ACPICA. Patch looks like this: Index: hwregs.c =================================================================== RCS file: /usr/cvs/src/sys/contrib/dev/acpica/hwregs.c,v retrieving revision 1.1.1.16 diff -u -r1.1.1.16 hwregs.c --- hwregs.c 3 May 2003 17:16:40 -0000 1.1.1.16 +++ hwregs.c 7 Jun 2003 14:23:57 -0000 @@ -510,8 +510,8 @@ ACPI_REGISTER_INSERT_VALUE (RegisterValue, BitRegInfo->BitPosition, BitRegInfo->AccessBitMask, Value); - Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK, RegisterId, - (UINT16) RegisterValue); + Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK, + ACPI_REGISTER_PM1_CONTROL, (UINT16) RegisterValue); break; Glad to hear your other problems have been solved. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/