Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Jan 2000 14:16:23 -0500 (EST)
From:      Luoqi Chen <luoqi@watermarkgroup.com>
To:        FreeBSD-current@FreeBSD.ORG, FreeBSD-hackers@FreeBSD.ORG, kato@ganko.eps.nagoya-u.ac.jp
Cc:        FreeBSD98-hackers@jp.freebsd.org, nyan@jp.freebsd.org
Subject:   Re: indirection in bus space
Message-ID:  <200001241916.OAA08645@lor.watermarkgroup.com>

next in thread | raw e-mail | index | archive | help
> Do you have any comment anout the patch?  If there isn't any big
> problem, I hope to commit it to current.
> 
> Thank you.
> 
> 
> I wrote:
> > Do you remember this topic?  I have revised the indirection support
> > patch.  What I have changed are:
> >   - to make diff files more readable
> >   - introduce the bus_simple_create_bsh() that creates
> >     a bus_space_handle_tag from a base address.
> > 
>
We shouldn't need bus_simple_create_bsh(). All drivers ought to use
rman_get_bushandle()/rman_get_bustag() to retrieve the bus handle and tag,
and use them in bus_space_read/write calls to perform device io. Drivers
that don't do that should be fixed.

Why have two files bus_at386.h and bus_pc98.h? I386_BUS_PIO_IND should be
able to live with I386_BUS_PIO and I386_BUS_MEMIO happily together.

-lq


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001241916.OAA08645>