Date: Wed, 8 Aug 2018 23:34:46 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Ryan Steinmetz <zi@freebsd.org> Cc: Adam Weinberger <adamw@adamw.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476670 - in head/devel: . rubygem-solve Message-ID: <20180808213446.gktmjqcyrfhjkrlk@atuin.in.mat.cc> In-Reply-To: <20180808202929.GA63276@exodus.zi0r.com> References: <201808081953.w78Jr68X078029@repo.freebsd.org> <CAP7rwciJj9U0TOEvnwSCc2hCWh_NF44pPjHfmQRu8MGCYq24AA@mail.gmail.com> <20180808202929.GA63276@exodus.zi0r.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--cuq5gkvnuduxeed3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 08, 2018 at 04:29:29PM -0400, Ryan Steinmetz wrote: >=20 > On (08/08/18 14:17), Adam Weinberger wrote: > > On Wed, Aug 8, 2018 at 1:53 PM Ryan Steinmetz <zi@freebsd.org> wrote: > > > +COMMENT=3D A ruby version constraint solver > > >=20 > > >=20 > > > Added: head/devel/rubygem-solve/pkg-descr > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/devel/rubygem-solve/pkg-descr Wed Aug 8 19:53:06 2018 = (r476670) > > > @@ -0,0 +1,3 @@ > > > +A Ruby version constraint solver. > > > + > > > +WWW: https://rubygems.org/gems/solve > > >=20 > >=20 > > Ryan, > >=20 > > You've just added a number of ports with uninformative pkg-descrs, and > > unhelpful COMMENT strings. These aren't merely formalities. Users > > should be able to read the pkg-descr and understand if it's the right > > package for them, and COMMENT is the first target for searches. > > Please, go back over them and, at the very least, expand the pkg-descr > > files with more information. As a general rule, pkg-descr should NEVER > > be the same text as the COMMENT. >=20 > Adam, >=20 > These are the description strings from authors of the code. They came fr= om > either rubygems.org and/or the gem source repository. For example, in the > case of rubygem-solve: >=20 > https://rubygems.org/gems/solve >=20 > https://github.com/berkshelf/solve >=20 > If you have any specific things you would like to see added to any of the > individual ports, please let me know. pkg-descr must contain sentences, something that can be read. It must at least be two lines long, so that it is descriptive enough. The fact that upstream is crappy does not mean you can put he same crap in the ports tree. It is your job as committer to make sure that ports conform to our policies and requirements. If upstream does not provide a better decription, create one, basd on your knowledge of the software. --=20 Mathieu Arnold --cuq5gkvnuduxeed3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltrYfZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgnqA/+NsjxbfgDcLJoQgQFlJmUN7mAs+oJHBYcWsJy/m5jG/7TPsbONGNpY0xT ewdNiM8uN28ye7qoMiZKSHYy21X2qg9pj4FuYa1FNlDvakh1UqEgxDrOEop+ZBve iy78UTAKp8XVUsuB/WfPeYitOWPPp8AbNIEdiEmOtblLD4yfArOE2U3D+ekL8e4a MKX3wIw2pqiOFacjvA6HbY884eAcdM1dseeu0RzRlkk2IDnRrzxXU9+XH7b8PapK NKfov37iBnrHHfocEv4aDfAesTB8jxqAfCEZjamwg5Rnv8+F+ACoc2onKRwlSIWO I0gEtSPdprUch8aOP1Rhv+UrNLjqBjPXqfQ0DYSQ/53Ml80dNf4rrs6qE6cfgOC8 Pfrnq8nkkAK+NEZ2xSSg9Aqb0eiNhp60YXr8PURADzs9f4xSg2tHg0ij7ihdO4d6 a7osdJbiu3wo9Di4bM0d6nJgv7H7vO5ZgIF4cJPWfJ/ORW4ScFOYLTCx6GbxjJcQ x6A8mLS1fN4dhM3NkmUhTghalKMOJNUiofZPMVuP39FqivJ46AH9X8qFbDAJRNVz pikPRHkSyrcoJxsY0nNgI4iAlGLHsALazvjQMK1XxX8CeRD2kkbizZ9oujv0iqLQ qd+AnW1HoFx4OmVnUz1CgaGjoXGSEGd+N6sZFp6GGexDSjfXL6E= =pO8d -----END PGP SIGNATURE----- --cuq5gkvnuduxeed3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180808213446.gktmjqcyrfhjkrlk>