Date: Fri, 14 Jan 2022 23:41:22 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: dev-commits-src-all@FreeBSD.org, Daniel Ebdrup Jensen <debdrup@FreeBSD.org>, dev-commits-src-main@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces Message-ID: <493738071.2419.1642200082113@localhost> In-Reply-To: <202201142044.20EKirZj000512@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_2418_1796675345.1642200082110 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Van: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> Datum: 14 januari 2022 21:45 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commi= ts-src-main@FreeBSD.org Onderwerp: git: 9f0b56872c1f - main - carp(4): Make regex additionally matc= h on VLAN interfaces >=20 >=20 > The branch main has been updated by debdrup (doc committer): >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9f0b56872c1fb790f67ee45a56= ceeeed5d17ddea >=20 > commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea > Author: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > AuthorDate: 2022-01-14 20:32:06 +0000 > Commit: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > CommitDate: 2022-01-14 20:44:13 +0000 >=20 > carp(4): Make regex additionally match on VLAN interfaces > =20 > This tiny change to the example makes devd capable of reacting to car= p > status change events on VLAN interfaces. > =20 > Reported by: Thomas Steen Rasmussen (tykling) <thomas at gibfest.d= k> > --- > share/man/man4/carp.4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4 > index 8d54d56afa03..2785b97e76ac 100644 > --- a/share/man/man4/carp.4 > +++ b/share/man/man4/carp.4 > @@ -290,7 +290,7 @@ status change events can be set up by using the follo= wing devd.conf rule: > .Bd -literal -offset indent > notify 0 { > match "system" "CARP"; > - match "subsystem" "[0-9]+@[0-9a-z]+"; > + match "subsystem" "[0-9]+@[0-9a-z.]+"; > match "type" "(MASTER|BACKUP)"; > action "/root/carpcontrol.sh $subsystem $type"; > }; >=20 >=20 >=20 >=20 >=20 Hi, I don=E2=80=99t think you need to escape a dot inside a character class. But maybe this regex engine does need it.=20 Nice change about the vlan though.=20 Regards, Ronald ------=_Part_2418_1796675345.1642200082110 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head></head><body><br /><p><small><strong>Van:</strong> Daniel Ebdru= p Jensen <debdrup@FreeBSD.org><br /><strong>Datum:</strong> 14 januar= i 2022 21:45<br /><strong>Aan:</strong> src-committers@FreeBSD.org, dev-com= mits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org<br /><strong>Ond= erwerp:</strong> git: 9f0b56872c1f - main - carp(4): Make regex additionall= y match on VLAN interfaces<br /></small></p><blockquote style=3D"margin-lef= t: 5px; border-left: 3px solid #ccc; margin-right: 0px; padding-left: 5px;"= ><div class=3D"MessageRFC822Viewer do_not_remove" id=3D"P"><!-- P --> <!-- processMimeMessage --><div class=3D"TextPlainViewer do_not_remove" id= =3D"P.P"><!-- P.P -->The branch main has been updated by debdrup (doc commi= tter):<br /> <br /> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D9f0b56872c1fb790f= 67ee45a56ceeeed5d17ddea">https://cgit.FreeBSD.org/src/commit/?id=3D9f0b5687= 2c1fb790f67ee45a56ceeeed5d17ddea</a><br /> <br /> commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea<br /> Author: Daniel Ebdrup Jensen <debdrup@FreeBSD.or= g><br /> AuthorDate: 2022-01-14 20:32:06 +0000<br /> Commit: Daniel Ebdrup Jensen <debdrup@FreeBSD.or= g><br /> CommitDate: 2022-01-14 20:44:13 +0000<br /> <br /> carp(4): Make regex additionally match on VLAN inte= rfaces<br /> <br /> This tiny change to the example makes devd capable = of reacting to carp<br /> status change events on VLAN interfaces.<br /> <br /> Reported by: Thomas Steen Rasmuss= en (tykling) <thomas at gibfest.dk><br /> ---<br /> share/man/man4/carp.4 | 2 +-<br /> 1 file changed, 1 insertion(+), 1 deletion(-)<br /> <br /> diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4<br /> index 8d54d56afa03..2785b97e76ac 100644<br /> --- a/share/man/man4/carp.4<br /> +++ b/share/man/man4/carp.4<br /> @@ -290,7 +290,7 @@ status change events can be set up by using the followi= ng devd.conf rule:<br /> .Bd -literal -offset indent<br /> notify 0 {<br /> match "system" &n= bsp; "CARP";<br /> - match "subsystem" &nb= sp;"[0-9]+@[0-9a-z]+";<br /> + match "subsystem" &nb= sp;"[0-9]+@[0-9a-z.]+";<br /> match "type" &nbs= p; "(MASTER|BACKUP)";<br /> action "/root/carpcontrol.sh $subsystem $type&= quot;;<br /> };<br /> <br /> </div><!-- TextPlainViewer --> <hr /> </div><!-- MessageRFC822Viewer --> </blockquote><br /><br />Hi,<div><br />I don=E2=80=99t think you need to es= cape a dot inside a character class.<div>But maybe this regex engine does n= eed it. <br /><div><br /></div><div>Nice change about the vlan though.= </div><div><br /></div><div>Regards,</div><div>Ronald<br /><br /></di= v></div></div></body></html> ------=_Part_2418_1796675345.1642200082110--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493738071.2419.1642200082113>