Date: Thu, 14 Jan 2010 15:20:03 GMT From: Bernhard Schmidt <bschmidt@techwires.net> To: freebsd-net@FreeBSD.org Subject: Re: kern/142018: [iwi] [patch] Possibly wrong interpretation of beacon-> number in if_iwi.c Message-ID: <201001141520.o0EFK2B1022257@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/142018; it has been noted by GNATS.
From: Bernhard Schmidt <bschmidt@techwires.net>
To: bug-followup@freebsd.org, Andre.Albsmeier@siemens.com
Cc:
Subject: Re: kern/142018: [iwi] [patch] Possibly wrong interpretation of beacon->number in if_iwi.c
Date: Thu, 14 Jan 2010 16:10:28 +0100
Hi,
It might be simple endianess related issue, does this patch make any
difference?
Index: if_iwi.c
===================================================================
--- sys/dev/iwi/if_iwi.c (revision 202285)
+++ sys/dev/iwi/if_iwi.c (working copy)
@@ -1499,9 +1499,9 @@ iwi_notification_intr(struct iwi_softc *sc, struct
beacon = (struct iwi_notif_beacon_state *)(notif + 1);
DPRINTFN(5, ("Beacon state (%u, %u)\n",
- beacon->state, le32toh(beacon->number)));
+ le32toh(beacon->state), le32toh(beacon->number)));
- if (beacon->state == IWI_BEACON_MISS) {
+ if (le32toh(beacon->state) == IWI_BEACON_MISS) {
/*
* The firmware notifies us of every beacon miss
* so we need to track the count against the
--
Bernhard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001141520.o0EFK2B1022257>