From owner-cvs-lib Thu Dec 12 21:23:07 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id VAA18467 for cvs-lib-outgoing; Thu, 12 Dec 1996 21:23:07 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id VAA18448; Thu, 12 Dec 1996 21:22:56 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id QAA20872; Fri, 13 Dec 1996 16:21:17 +1100 Date: Fri, 13 Dec 1996 16:21:17 +1100 From: Bruce Evans Message-Id: <199612130521.QAA20872@godzilla.zeta.org.au> To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, joerg@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net ascii2addr.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: lib/libc/net ascii2addr.c > Log: > Fix an embarassing and rather obscure incarnation of an uninitialized > local variable use. > > Found by: actually using ascii2addr() :-/ This introduces an embarassing and rather obscure incarnation of an uninitialized local variable use: now strbuf[15] is uninitialized. strncpy(), unlike strncat(), does not null terminate the target string if the source string together with its null terminator is longer than the specified length. Bruce