From owner-freebsd-hackers@FreeBSD.ORG Thu Jan 6 19:15:09 2011 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 21CCD1065673 for ; Thu, 6 Jan 2011 19:15:09 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D45E58FC22 for ; Thu, 6 Jan 2011 19:15:08 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p06J63Ca033353 for ; Thu, 6 Jan 2011 12:06:03 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D261299.6090003@bsdimp.com> Date: Thu, 06 Jan 2011 12:06:01 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: freebsd-hackers@FreeBSD.org References: <20110106014046.GA324@freebsd.org> <20110106134531.GA81523@freebsd.org> In-Reply-To: <20110106134531.GA81523@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: broken INCLUDE in sys/conf/kern.pre.mk for opensolaris code? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2011 19:15:09 -0000 On 01/06/2011 06:45, Alexander Best wrote: > On Thu Jan 6 11, Sergey Kandaurov wrote: >> On 6 January 2011 04:40, Alexander Best wrote: >>> hi there, >>> >>> while building target buildkernel with 'clang -v' i noticed a lot of these >>> lines: >>> >>> ignoring nonexistent directory "/usr/subversion-src/sys/contrib/opensolaris/compat" >>> >>> i checked sys/conf/kern.pre.mk and there's a line refering to a non-existing >>> directory: >>> >>> # ... and OpenSolaris >>> INCLUDES+= -I$S/contrib/opensolaris/compat >> I guess that's leftover from early dtrace stages in perforce. >> See //depot/projects/dtrace/src/sys/contrib/opensolaris/compat/sys > ah i see. whom do i have to ping to get this fixed? i'm not sure if the include > is even necessary, because obviosly a kernel will build without it. the only > issue i had with cddl code is that when you compile and install world with > WITHOUT_CDDL=true, you cannot rebuild world with cddl support. but i don't > think that's something the include (even if it points to the correct directory) > can fix. Maybe we should just remove it and be on our way. Warner > cheers. > alex > >>> is suspect this should actually be: >>> >>> # ... and OpenSolaris >>> INCLUDES+= -I$S/cddl/compat/opensolaris >>> >>> but i'm not sure of it. >>> >> >> -- >> wbr, >> pluknet