From nobody Thu Oct 16 18:50:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cncTW4zN5z6Cxt9; Thu, 16 Oct 2025 18:50:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cncTW0WpZz3G5N; Thu, 16 Oct 2025 18:50:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760640623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VzT6hrk6O2GGl9tp9Ei1KK3wiZnJSbyTdkgejbBBBVc=; b=DQ3Z2/lIV9w1/2+D18tzSk5BY0BEKs7zOzAUGqmyjJeHBaG85wCkS5DJjO8Bxlx/+lDBBu 1T1Q/P3XWxnsRSVtkqu8ba/n8Y8nmOL7AtqIqLPOO914HbN289+P/GDi61PEpwMJaP85Z3 qIHIU0uxoE1kCCWo5hJNsdRI0lggdbYzIAwuJOQdyNSKT8wABU5hin0Y0smXC1pmBpD1Un GGDCp/d0Jx4pKFmNt7Jt2xDpFtllI8gJsl96GcjFSrdpEwX3/9fHrocTgNx5ra64kS6pd2 XTKpZaRX1l+etMq3jETyUsqiJdTbf/T5ZBUaZ9xenoYfTt7MX49qcGUoNaIXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760640623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VzT6hrk6O2GGl9tp9Ei1KK3wiZnJSbyTdkgejbBBBVc=; b=lSk1xSDzFBIbbC1sJ3pts0fi19rE+xK/w72WsgvPHuNHQHETv4LWoVt377aW3IRjSL+S2K l1gUj4cDBxZg9hxkzXLcx6sfCMGEJPSZFpSi7T4ABdmuC+CxRu4U+WnUPtVig3gK47zlHh vcjnAUCluDjejlrdHadqa/EVETkpzgVaWEFV1SPel5US0tqRN25ie50L4mYDK39OE5fOpM A5hD2iXkR2MR9Bl6co85BYiMSrzByxe+HNE+HwqOT+xrs3xkT9p/d5EajEMnbKjlMrrtgc 8KysKdmPQbYBSAj89Y7x0QlusT94dqtYnPZfZl4SXg0AHOyvn7ccPfWMEPl0pA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760640623; a=rsa-sha256; cv=none; b=H3fEPv27jN1mAcVs7b6uXDUOouPMsPUOaK/wRzZo8ghimk71O7WMHK32stWJPjViJQG/nd remgkwtxktY0Bb0tqUYuj7/3l3YwgDU+OjU3HWzwYfHCBR0lvuWZJ1pzN6qZYeDzfkoV+h RsZKKx9LkzyqyBu0A0CK1hIuWXUElLf17kePcwLfJ5SgFIB9u+ktW0usELX5a81zsNbCwn zvpcmRs5R9F/TcdQKAyLqZwiuT+dQPwUnAZBr0lfVlRfXJFiKJDNIuI5JxxB8i4nAH3/aj Fik+VL+9c16xUAvu99BU3+JJ8MFcOppKRZY98ZFPB6o3jq8PAso56kmJlqxnNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cncTV70hlz4nT; Thu, 16 Oct 2025 18:50:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59GIoMnj075197; Thu, 16 Oct 2025 18:50:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59GIoMb1075194; Thu, 16 Oct 2025 18:50:22 GMT (envelope-from git) Date: Thu, 16 Oct 2025 18:50:22 GMT Message-Id: <202510161850.59GIoMb1075194@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: d14f6f170453 - releng/15.0 - sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (2/2) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: d14f6f17045395572b605b4f00b2d9b40fff98a8 Auto-Submitted: auto-generated The branch releng/15.0 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=d14f6f17045395572b605b4f00b2d9b40fff98a8 commit d14f6f17045395572b605b4f00b2d9b40fff98a8 Author: Olivier Certner AuthorDate: 2025-10-07 13:33:53 +0000 Commit: Colin Percival CommitDate: 2025-10-16 18:48:11 +0000 sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (2/2) Remove local defines from 'svc_auth_unix.c' and use the new limit macros instead. Approved by: re (cperciva) Reviewed by: rmacklem MFC after: 2 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52963 (cherry picked from commit e665c0f6f7a611d25d9d7e7f64d98c84b3a92820) (cherry picked from commit 9763e76cccf05d405e0fd9c9c351808993e93b14) --- sys/rpc/svc_auth_unix.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sys/rpc/svc_auth_unix.c b/sys/rpc/svc_auth_unix.c index aad4e7610795..b3389bc79511 100644 --- a/sys/rpc/svc_auth_unix.c +++ b/sys/rpc/svc_auth_unix.c @@ -50,9 +50,6 @@ #include -#define MAX_MACHINE_NAME 255 -#define NGRPS 16 - /* * Unix longhand authenticator */ @@ -76,7 +73,7 @@ _svcauth_unix(struct svc_req *rqst, struct rpc_msg *msg) if (buf != NULL) { time = IXDR_GET_UINT32(buf); str_len = (size_t)IXDR_GET_UINT32(buf); - if (str_len > MAX_MACHINE_NAME) { + if (str_len > AUTH_SYS_MAX_HOSTNAME) { stat = AUTH_BADCRED; goto done; } @@ -85,7 +82,7 @@ _svcauth_unix(struct svc_req *rqst, struct rpc_msg *msg) xcr->cr_uid = IXDR_GET_UINT32(buf); xcr->cr_gid = IXDR_GET_UINT32(buf); supp_ngroups = (size_t)IXDR_GET_UINT32(buf); - if (supp_ngroups > NGRPS) { + if (supp_ngroups > AUTH_SYS_MAX_GROUPS) { stat = AUTH_BADCRED; goto done; }