From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Oct 27 15:29:02 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 63E494C1
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 27 Oct 2014 15:29:02 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4A8E7760
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 27 Oct 2014 15:29:02 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s9RFT2pf022127
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 27 Oct 2014 15:29:02 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 193135] [NEW PORT] www/seahub: Seafile web server front end
Date: Mon, 27 Oct 2014 15:29:02 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: Patch Ready
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-193135-13-h3Jl2L6hYC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193135-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-193135-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 15:29:02 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193135

John Marino <marino@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino@FreeBSD.org

--- Comment #18 from John Marino <marino@FreeBSD.org> ---
I'm sorry nobody has looked at this for, well, 2 months.  It looks ok to me
except for this:

Xdo-install:
X    @${ECHO_MSG} ">>> Installing scripts..."
X    @${MKDIR} -m 0755 ${STAGEDIR}${HAIWENDIR}seafile-server/runtime/
X    @${INSTALL} -m 0755    ${WRKSRC}/runtime/seahub.conf \
X                        ${STAGEDIR}${HAIWENDIR}seafile-server/runtime/
X    @${MKDIR} -m 0755 ${STAGEDIR}${SEAHUBDIR}
X    @cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${SEAHUBDIR}
X    @${FIND} ${STAGEDIR}${SEAHUBDIR} -name "*.bak" -exec ${RM} {} \;
X    @${FIND} ${STAGEDIR}${SEAHUBDIR} -name "*.orig" -exec ${RM} {} \;

The "@" suppresses the command.  We only allow "@" suppression on mkdir
commands in the install and post-install targets.

Plus, while not technically wrong, I don't really like seeing post-extra and
post-patch.  Can you move the contents of post-extract to post-patch target? 
Especially since it gives us the opportunity to patch the .conf file if we need
to?

-- 
You are receiving this mail because:
You are the assignee for the bug.