Date: Thu, 14 Sep 2017 18:12:15 -0400 From: Steve Wills <swills@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449798 - head/net-mgmt/collectd5 Message-ID: <305b87d4-297e-e569-7011-9c322984206d@FreeBSD.org> In-Reply-To: <201709131455.v8DEtjVq069144@repo.freebsd.org> References: <201709131455.v8DEtjVq069144@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I'm happy to see more options enabled by default in this port, thanks for that. We do have a policy that packaged binaries should be stripped. Enabling the DEBUG option by default would seem to be at odds with that policy to me. Could you please turn that one off by default? Thanks, Steve On 09/13/2017 10:55, Dag-Erling Smørgrav wrote: > Author: des > Date: Wed Sep 13 14:55:45 2017 > New Revision: 449798 > URL: https://svnweb.freebsd.org/changeset/ports/449798 > > Log: > Enable the DEBUG, GCRYPT and PING options by default. > > DEBUG is required for any sort of troubleshooting, GCRYPT is required to > encrypt communication with the server, and PING is one of the most basic > sensors which everybody uses. My hope is that with these three options, > more people will be able to use collectd without having to recompile it. > > Approved by: maintainer > > Modified: > head/net-mgmt/collectd5/Makefile > > Modified: head/net-mgmt/collectd5/Makefile > ============================================================================== > --- head/net-mgmt/collectd5/Makefile Wed Sep 13 14:45:29 2017 (r449797) > +++ head/net-mgmt/collectd5/Makefile Wed Sep 13 14:55:45 2017 (r449798) > @@ -3,6 +3,7 @@ > > PORTNAME= collectd > PORTVERSION= 5.7.2 > +PORTREVISION= 1 > CATEGORIES= net-mgmt > MASTER_SITES= https://collectd.org/files/ \ > http://collectd.org/files/ > @@ -26,6 +27,8 @@ OPTIONS_GROUP_INPUT= CHRONY CURL CURL_JSON CURL_XML DB > PERL PGSQL PINBA PING PYTHON RABBITMQ REDIS ROUTEROS \ > SIGROK SNMP STATSD TOKYOTYRANT VARNISH XML \ > XMMS ZOOKEEPER > + > +OPTIONS_DEFAULT= DEBUG GCRYPT PING > > CGI_DESC= Install collection.cgi (requires rrdtool) > CHRONY_DESC= Enable chronyd plugin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?305b87d4-297e-e569-7011-9c322984206d>