From owner-svn-src-all@freebsd.org Fri Aug 25 23:18:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C111BDE3A07; Fri, 25 Aug 2017 23:18:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8391374AE6; Fri, 25 Aug 2017 23:18:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id B8E0E1899F; Fri, 25 Aug 2017 23:18:23 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id A7D918A4C; Fri, 25 Aug 2017 23:18:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id CPjV7Wi9Z9lW; Fri, 25 Aug 2017 23:18:15 +0000 (UTC) Subject: Re: svn commit: r306512 - in head/sys: kern sys DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 80B4D8A46 To: Konstantin Belousov Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201609301727.u8UHRIgD051373@repo.freebsd.org> <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org> <20170825103534.GK1700@kib.kiev.ua> <20170825223752.GN1700@kib.kiev.ua> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <25ad986d-7a39-7854-5680-390c20a16743@FreeBSD.org> Date: Fri, 25 Aug 2017 16:17:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170825223752.GN1700@kib.kiev.ua> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 23:18:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln Content-Type: multipart/mixed; boundary="XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp"; protected-headers="v1" From: Bryan Drewery To: Konstantin Belousov Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <25ad986d-7a39-7854-5680-390c20a16743@FreeBSD.org> Subject: Re: svn commit: r306512 - in head/sys: kern sys References: <201609301727.u8UHRIgD051373@repo.freebsd.org> <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org> <20170825103534.GK1700@kib.kiev.ua> <20170825223752.GN1700@kib.kiev.ua> In-Reply-To: <20170825223752.GN1700@kib.kiev.ua> --XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/25/2017 3:37 PM, Konstantin Belousov wrote: > On Fri, Aug 25, 2017 at 02:29:28PM -0700, Bryan Drewery wrote: >> https://people.freebsd.org/~bdrewery/patches/vdrop-global-list.diff > I do not object against his handling. >=20 > There is really very small amount of code shared between mp !=3D NULL > and mp =3D=3D NULL cases, you may consider making them use separate pat= hs > instead of adding more than one check for mp !=3D NULL. >=20 Sure, and I incorrectly was adding VMP_TMPMNTFREELIST flag for mp=3D=3DNU= LL case. I'll open a review. > VNASSERT() statement has wrong indent on the continuation line. >=20 --=20 Regards, Bryan Drewery --XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp-- --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZoLAnAAoJEDXXcbtuRpfPRJ0IANds7jjlR2FGihpYQv0WqPvE 5ZGVBB8raABuIacEkeZUjnHP2eAcbNvAdg0LUvelIRRyTLKJI8pc/LR1tT45qZfU 36Zhher7I+75ymxYbnzhi/sQJ2CUiyzHORaByCJXHhVvUyysgEDNqyuZXCfF8fMB 3Kj+Ztlt8e5da4f6GPnzJSxG0qzzuU+JqMALWWu5rfNToUH0HyYOphMu+rqcgPki TvZ6z5rVgwMf6SfWpOvTf6qZh0p7Lt3wkKGdvpA96arkiGFCyBfUl3COkcr+5OU1 UTaOU5iQE2hD2RXneiIYi0vYnIkaKSBCMn0Y58EchGA6q4UBUFXGaai6wjSpi0c= =84mS -----END PGP SIGNATURE----- --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln--