From owner-svn-src-all@FreeBSD.ORG Thu Jan 12 17:07:34 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED9F5106567A; Thu, 12 Jan 2012 17:07:33 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id EF6E68FC1F; Thu, 12 Jan 2012 17:07:32 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:a06e:a9a1:daf:164d] (unknown [IPv6:2001:7b8:3a7:0:a06e:a9a1:daf:164d]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C10F65C37; Thu, 12 Jan 2012 18:07:31 +0100 (CET) Message-ID: <4F0F1355.2010709@FreeBSD.org> Date: Thu, 12 Jan 2012 18:07:33 +0100 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120106 Thunderbird/10.0 MIME-Version: 1.0 To: Jung-uk Kim References: <201010131033.o9DAX1EE080534@svn.freebsd.org> <201010141505.14869.jkim@FreeBSD.org> <201010141523.29842.jkim@FreeBSD.org> In-Reply-To: <201010141523.29842.jkim@FreeBSD.org> Content-Type: multipart/mixed; boundary="------------020707010109000404020808" Cc: src-committers@freebsd.org, Rui Paulo , John Baldwin , svn-src-all@freebsd.org, Dmitry Morozovsky , svn-src-head@freebsd.org, John Nielsen , Peter Grehan Subject: Re: svn commit: r213765 - head/sys/dev/aic7xxx/aicasm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:07:34 -0000 This is a multi-part message in MIME format. --------------020707010109000404020808 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2010-10-14 21:23, Jung-uk Kim wrote: > On Thursday 14 October 2010 03:11 pm, Dmitry Morozovsky wrote: >> On Thu, 14 Oct 2010, Jung-uk Kim wrote: ... >> cc -O2 -pipe -nostdinc -I/usr/include -I. >> -I/FreeBSD/src.current.svn/sys/dev/aic7xxx/aicasm -std=gnu99 >> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W >> -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes >> -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch >> -Wshadow -Wunused-parameter -Wcast-align -Wno-pointer-sign -c >> aicasm_scan.c >> cc1: warnings being treated as errors >> /FreeBSD/src.current.svn/sys/dev/aic7xxx/aicasm/aicasm_scan.l:840: >> warning: function declaration isn't a prototype ... > Hmm... That means "make buildkernel" did not pick up newly built lex. > That's bad. :-( I know it's very, very late to respond to this, but I just had an email conversation with Peter Grehan, where he ran into this problem when attempting to build -CURRENT on 8.1-RELEASE. This doesn't have the followup r214779 yet, where the needed update to lex is merged. Of course, I also know that building -CURRENT on 8.1-RELEASE is officially not supported, but if there is a relatively simple fix to make it work, it should not be a problem to apply, right? :) The root of the problem is that, even if buildworld is completed, the "stage 2.3: build tools" (kernel-specific) part of Makefile.inc1 uses lex and yacc from /usr/bin, *not* the ones built under ${WORLDTMP} (usually in /usr/obj/usr/src/tmp/legacy/usr/bin). Therefore, I propose to set PATH to ${BPATH}:${PATH} in this stage, so the "good" versions of lex and yacc are used. As per attached diff. (NOTE: even with this diff applied, doing 'make buildkernel' without first doing 'make buildworld' or 'make kernel-toolchain' will not work, because there will be no copy of lex and yacc in /usr/obj.) --------------020707010109000404020808 Content-Type: text/x-diff; name="fix-aicasm-lex-yacc-1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-aicasm-lex-yacc-1.diff" Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 229979) +++ Makefile.inc1 (working copy) @@ -832,6 +832,7 @@ @echo ">>> stage 2.3: build tools" @echo "--------------------------------------------------------------" cd ${KRNLOBJDIR}/${_kernel}; \ + PATH=${BPATH}:${PATH} \ MAKESRCPATH=${KERNSRCDIR}/dev/aic7xxx/aicasm \ ${MAKE} SSP_CFLAGS= -DNO_CPU_CFLAGS -DNO_CTF \ -f ${KERNSRCDIR}/dev/aic7xxx/aicasm/Makefile @@ -839,6 +840,7 @@ .if !defined(MODULES_WITH_WORLD) && !defined(NO_MODULES) && exists(${KERNSRCDIR}/modules) .for target in obj depend all cd ${KERNSRCDIR}/modules/aic7xxx/aicasm; \ + PATH=${BPATH}:${PATH} \ MAKEOBJDIRPREFIX=${KRNLOBJDIR}/${_kernel}/modules \ ${MAKE} SSP_CFLAGS= -DNO_CPU_CFLAGS -DNO_CTF ${target} .endfor --------------020707010109000404020808--