From owner-svn-src-all@freebsd.org Thu Aug 8 02:39:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AFFFBC120D; Thu, 8 Aug 2019 02:39:12 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463syR4dtHz3F4n; Thu, 8 Aug 2019 02:39:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f66.google.com with SMTP id r21so106654927otq.6; Wed, 07 Aug 2019 19:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=yReDWTZcI1Q1R4sK8ZLH/khjCkVUGP0/VTmZaEA4Dxw=; b=HeI0VfSDX9ZDyYmjbzYnZTavhyEsOUoTpxoXYwibluSjzRvG4wRCHIY6uI/XSTrVGj gRFNHHEC7Qzi8OuUSNO5YLKKkrcVo2GlW2mpU+UTgVL1X1ATkXp0dMT/SJRkvbw1rsGy skEDeDUyJQbHpJehJHgiJ9xiWoj+P8AkdTlzNhUHo7uJQZ/IHWTBE1t3vs4epGOe/PEZ Q1OLBlgkh3VqKbKKTFaQepv3cXUXp0jqzgiTVWIK+jbtvVupYsWS38NtnKmLgaUcdBsT oWtEEXP/JM9I1oVU4ya5L2U2SvKJ4NnmEDvKjWCuMWob9CU42heoLpDXNVOZHzLWonqk bj8Q== X-Gm-Message-State: APjAAAWYyzrKCZqQC6RQYuicNep1ttwUs8JPyL0lY7XQJEbRFRMCf+jK GCBpYjF3dB5TeyP4BsZYbDhXloNv X-Google-Smtp-Source: APXvYqyaF4ux3Ib969chfBISQVnIweYDSRv/ec9XuO9PaSeugzPjhFNDHIbvgT2M+wRmSPpnO4IrSg== X-Received: by 2002:aca:b808:: with SMTP id i8mr906696oif.163.1565231950085; Wed, 07 Aug 2019 19:39:10 -0700 (PDT) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com. [209.85.210.48]) by smtp.gmail.com with ESMTPSA id v203sm35642980oie.5.2019.08.07.19.39.09 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 19:39:09 -0700 (PDT) Received: by mail-ot1-f48.google.com with SMTP id o101so112643392ota.8; Wed, 07 Aug 2019 19:39:09 -0700 (PDT) X-Received: by 2002:a6b:6409:: with SMTP id t9mr1589050iog.270.1565231948982; Wed, 07 Aug 2019 19:39:08 -0700 (PDT) MIME-Version: 1.0 References: <201907250546.x6P5kHWq076756@repo.freebsd.org> In-Reply-To: <201907250546.x6P5kHWq076756@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 7 Aug 2019 19:38:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r350315 - in head/sys: kern sys To: Rick Macklem Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 463syR4dtHz3F4n X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.66 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-4.77 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; RWL_MAILSPIKE_GOOD(0.00)[66.210.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.999,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; IP_SCORE(-1.77)[ip: (-3.00), ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.43), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[66.210.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 02:39:12 -0000 Hi Rick, Coverity reports that the following portion of vn_generic_copy_file_range() is deadcode (CID 1403974), and it is: On Wed, Jul 24, 2019 at 10:46 PM Rick Macklem wrote: > > Author: rmacklem > Date: Thu Jul 25 05:46:16 2019 > New Revision: 350315 > URL: https://svnweb.freebsd.org/changeset/base/350315 > > Log: > Add kernel support for a Linux compatible copy_file_range(2) syscall. > ... > Modified: head/sys/kern/vfs_vnops.c > ============================================================================== > --- head/sys/kern/vfs_vnops.c Thu Jul 25 03:55:05 2019 (r350314) > +++ head/sys/kern/vfs_vnops.c Thu Jul 25 05:46:16 2019 (r350315) > ... > +int > +vn_generic_copy_file_range(struct vnode *invp, off_t *inoffp, > + struct vnode *outvp, off_t *outoffp, size_t *lenp, unsigned int flags, > + struct ucred *incred, struct ucred *outcred, struct thread *fsize_td) > +{ > ... > + error = vn_lock(invp, LK_SHARED); > + if (error != 0) > + goto out; // error is now zero > + if (VOP_PATHCONF(invp, _PC_MIN_HOLE_SIZE, &holein) != 0) > + holein = 0; > + VOP_UNLOCK(invp, 0); // the following condition is impossible: > + if (error != 0) > + goto out; Best, Conrad