From owner-freebsd-x11@freebsd.org Tue Feb 25 18:05:12 2020 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CC0FE23ABEB for ; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48Rn083fqqz4V1c for ; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6C52923ABE9; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) Delivered-To: x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6C12223ABE7 for ; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Rn081Lt9z4V1X for ; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 291011A812 for ; Tue, 25 Feb 2020 18:05:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01PI5CwI047963 for ; Tue, 25 Feb 2020 18:05:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01PI5CRk047952 for x11@FreeBSD.org; Tue, 25 Feb 2020 18:05:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 244404] x11/xdm: stray #endif in installed Xresources.sample Date: Tue, 25 Feb 2020 18:05:12 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 18:05:12 -0000 Bugzilla Automation has asked freebsd-x11 mailing li= st for maintainer-feedback: Bug 244404: x11/xdm: stray #endif in installed Xresources.sample https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244404 --- Description --- Using xdm 1.1.12, I get an error in xdm.log when starting a session: xdm info (pid 3008): Starting X server on :0 /usr/local/etc/X11/xdm/Xresources:67:2: error: #endif without #if #endif /* XPM */ The original source file has: #ifdef XPM XHASHif PLANES >=3D 8 xlogin*logoFileName: BITMAPDIR/XDM_PIXMAP XHASHelse xlogin*logoFileName: BITMAPDIR/XDM_BWPIXMAP XHASHendif xlogin*useShape: true xlogin*logoPadding: 10 #endif /* XPM */ and the "#ifdef XPM" is not present in the installed file, only the extra #endif.