From owner-freebsd-current@FreeBSD.ORG  Sat Feb 21 12:05:48 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8EDF516A4CE; Sat, 21 Feb 2004 12:05:48 -0800 (PST)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.10/8.12.9) with ESMTP id i1LK5lHS056922;
	Sat, 21 Feb 2004 15:05:47 -0500 (EST)
	(envelope-from green@green.homeunix.org)
Received: from localhost (green@localhost)i1LK5k2o056919;
	Sat, 21 Feb 2004 15:05:46 -0500 (EST)
Message-Id: <200402212005.i1LK5k2o056919@green.homeunix.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Peter Schultz <pmes@bis.midco.net>
In-Reply-To: Message from Peter Schultz <pmes@bis.midco.net> 
   of "Sat, 21 Feb 2004 13:37:59 CST." <4037B397.4040405@bis.midco.net> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 21 Feb 2004 15:05:46 -0500
Sender: green@green.homeunix.org
cc: current@FreeBSD.org
Subject: Re: Testers wanted: reentrant resolver 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Feb 2004 20:05:49 -0000

Peter Schultz <pmes@bis.midco.net> wrote:
> Brian F. Feldman wrote:
> > Patch updated :)
> > <URL:http://green.homeunix.org/~green/reentrant_resolver.patch>
> > 
> 
> Technicalities aside, this patch rules!
> 
> Thanks,
> Pete...
> 
> P.S.  Fundakowski?!?!  What a fine name!  8^)

Thanks ;-)  Okay, I found and fixed the MAJOR bug that was screwing things 
up -- the "s" field in res_send.c was not being initialized to -1, but to 0! 
This resulted in whatever was residing at fd 0 being closed if it responded 
to kqueue() (for the read event)!  This also appears to be why I was seeing 
resolvers sometimes take five minutes.

The patch has been updated; everyone, please try it now if you saw streams 
randomly being closed in mozilla (which I did).  I am pretty confident in 
the behavior now, because I watched it with debugging printfs to make sure
res_close() never closed 0 ;-)

<URL:http://green.homeunix.org/~green/reentrant_resolver.patch>

Hopefully more people will test this now so I can feel confident and commit 
it.  It will be really nice to MFC, too, since -STABLE users also see this 
behavior just using -lc_r.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\