Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Jun 2013 11:31:58 +0200 (CEST)
From:      Geoffroy Desvernay <dgeo@centrale-marseille.fr>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/179805: [MAINTAINER] net-mgmt/netdisco: update to 1.3
Message-ID:  <20130621093158.5F51D1CD53@dgeo.sysadm.ec-m.fr>
Resent-Message-ID: <201306210940.r5L9e0bB080771@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179805
>Category:       ports
>Synopsis:       [MAINTAINER] net-mgmt/netdisco: update to 1.3
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 21 09:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Geoffroy Desvernay
>Release:        FreeBSD 9.1-STABLE amd64
>Organization:
Ecole Centrale de Marseille
>Environment:
System: FreeBSD dgeo.sysadm.ec-m.fr 9.1-STABLE FreeBSD 9.1-STABLE #0: Tue Jun 11 09:49:37 CEST 2013
>Description:
- re-correct startup script (forgotten in last update) (was chmodding / and /var/tmp in some cases !)
- Update to 1.3 (bugfix release)
  see http://sourceforge.net/p/netdisco/code/ci/ver_1_3/tree/ChangeLog
- add docs and message for database upgrades

Generated with FreeBSD Port Tools 0.99_7 (mode: update, diff: SVN)
>How-To-Repeat:
>Fix:

--- netdisco-1.3.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 321451)
+++ Makefile	(working copy)
@@ -2,15 +2,15 @@
 # $FreeBSD$
 
 PORTNAME=	netdisco
-PORTVERSION=	1.2
+PORTVERSION=	1.3
 CATEGORIES=	net-mgmt www
 MASTER_SITES=	SF
 
 MAINTAINER=	dgeo@centrale-marseille.fr
 COMMENT=	Web-based network management tool for moderate to large networks
 
-OPTIONS_DEFINE=	GRAPHVIZ MIBS
-OPTIONS_DEFAULT=GRAPHVIZ MIBS
+OPTIONS_DEFINE=	GRAPHVIZ MIBS DOCS
+OPTIONS_DEFAULT=GRAPHVIZ MIBS DOCS
 MIBS_DESC=	Depend on net-mgmt/netdisco-mibs
 GRAPHVIZ_DESC=	Install GraphViz for network map support
 
@@ -54,7 +54,7 @@
 CONFIG_FILES=	netdisco.conf netdisco.crontab netdisco-topology.txt \
 		netdisco_apache.conf netdisco_apache_dir.conf
 
-DOCS=		doc/*.pod doc/*.html INSTALL README* UPGRADE
+DOCFILES=	ChangeLog doc/*.pod INSTALL README* UPGRADE
 
 .include <bsd.port.pre.mk>
 
@@ -86,6 +86,7 @@
 	${REINPLACE_CMD} -e 's#%%WWWDIR%%#${WWWDIR}#g'		\
 			-e 's#%%PREFIX%%#${PREFIX}#g'		\
 			-e 's#%%DATADIR%%#${DATADIR}#g'		\
+			-e 's#%%DOCSDIR%%#${DOCSDIR}#g'		\
 			-e 's#%%NETDISCO_RUNDIR%%#${NETDISCO_RUNDIR}#g'		\
 			-e 's#%%NETDISCO_USER%%#${USERS}#g'		\
 			-e 's#%%NETDISCO_GROUP%%#${GROUPS}#g'		\
@@ -145,6 +146,10 @@
 .	endif
 
 post-install:
+.	if ${PORT_OPTIONS:MDOCS}
+		${MKDIR} ${DOCSDIR}
+		(cd ${WRKSRC} && ${INSTALL_MAN} ${DOCFILES} ${DOCSDIR})
+.	endif
 	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.post.mk>
Index: distinfo
===================================================================
--- distinfo	(revision 321451)
+++ distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (netdisco-1.2.tar.gz) = 18af19b5753eb752edf9d4fb7e8865628ac35cf7b60266c7d50da020e9994a1f
-SIZE (netdisco-1.2.tar.gz) = 1349238
+SHA256 (netdisco-1.3.tar.gz) = 8d69caa95ec3f62ca2ed886883447b9cfa63908188a2fe20bfefb27b860c2d72
+SIZE (netdisco-1.3.tar.gz) = 1350999
Index: files/netdisco.in
===================================================================
--- files/netdisco.in	(revision 321451)
+++ files/netdisco.in	(working copy)
@@ -25,13 +25,12 @@
 command="%%PREFIX%%/bin/netdisco"
 command_interpreter="/usr/bin/perl"
 netdisco_config="%%ETCDIR%%/netdisco.conf"
-pidfile=$(grep ^daemon_pid $netdisco_config | sed -E 's/.*=\s+//')
+pidfile=$(grep ^daemon_pid $netdisco_config | cut -d= -f2 | tail -1)
 flags="-p start"
 
 required_files="$netdisco_config"
 
 netdisco_prestart() {
-	test -d ${pidfile%/*} || install -d -m 0700 -o $netdisco_user -g $netdisco_group ${pidfile%/*}
 	touch $pidfile && chown $netdisco_user $pidfile
 	test -d %%NETDISCO_DBDIR%% || install -d -m 0700 -o $netdisco_user -g $netdisco_group %%NETDISCO_DBDIR%%
 }
Index: files/pkg-message.in
===================================================================
--- files/pkg-message.in	(revision 321451)
+++ files/pkg-message.in	(working copy)
@@ -4,13 +4,18 @@
 In order to get up and running, there are a few more steps to complete:
 
     1) Examine all the configuration files in %%ETCDIR%%,
-       and modify them to suit your needs.
+       and modify them to suit your needs. 
+       (check diff to the .sample if upgrading)
 
     2) You should consider downloading a fresh OUI database
        # fetch -o %%DATADIR%%/oui.txt http://standards.ieee.org/develop/regauth/oui/oui.txt
 
     3) Run the following to create and initialise the netdisco database:
        # perl %%DATADIR%%/sql/pg --init
+    OR (if upgrading)
+    3bis) Check %%DOCSDIR%%/ChangeLog and
+       %%DOCSDIR%%/UPGRADE%% and act accordingly
+       (databases upgrades are in %%DATADIR%%/sql)
 
     4) Add an initial admin user: 
        # su %%NETDISCO_USER%% -c "netdisco -u"
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 321451)
+++ pkg-plist	(working copy)
@@ -34,6 +34,7 @@
 %%DATADIR%%/sql/upgrade-0.95-to-1.0.sql
 %%DATADIR%%/sql/upgrade-1.0-to-1.1.sql
 %%DATADIR%%/sql/upgrade-1.1-to-1.2.sql
+%%DATADIR%%/sql/upgrade-1.2-to-1.3.sql
 %%DATADIR%%/sql/user_log.sql
 %%DATADIR%%/sql/users.sql
 %%DATADIR%%/Makefile
@@ -100,6 +101,18 @@
 %%WWWDIR%%/traffic.png
 %%WWWDIR%%/graphs_sample.mas
 %%WWWDIR%%/port_search.html
+%%DOCSDIR%%/ChangeLog
+%%DOCSDIR%%/DiscoveryDatabase.pod
+%%DOCSDIR%%/INSTALL.pod
+%%DOCSDIR%%/IPv6ArpNip.pod
+%%DOCSDIR%%/README.pod
+%%DOCSDIR%%/UPGRADE.pod
+%%DOCSDIR%%/WISHLIST.pod
+%%DOCSDIR%%/INSTALL
+%%DOCSDIR%%/README
+%%DOCSDIR%%/README-API-BACKEND
+%%DOCSDIR%%/README-API-SHARED
+%%DOCSDIR%%/UPGRADE
 @unexec d="%D/%%ETCDIR%%"; f="netdisco.conf"; if cmp -s ${d}/${f}.sample ${d}/${f}; then rm -f ${d}/${f}; fi;
 %%ETCDIR%%/netdisco.conf.sample
 @exec if [ ! -f %%ETCDIR%%/netdisco.conf ] ; then cp -p %%ETCDIR%%/netdisco.conf.sample %%ETCDIR%%/netdisco.conf; fi
@@ -123,4 +136,5 @@
 @dirrm %%DATADIR%%/sql
 @dirrmtry %%DATADIR%%
 @dirrmtry %%ETCDIR%%
+%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @exec mkdir -p %D/%%WWWDIR%%/mason
--- netdisco-1.3.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130621093158.5F51D1CD53>