Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jan 2006 11:45:06 +0200
From:      Vasil Dimov <vd@datamax.bg>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/91943: [patch] misc/tinderbox shouldn't allow no database to be selected
Message-ID:  <20060118094505.GA1779@qlovarnika.bg.datamax>
Resent-Message-ID: <200601180950.k0I9o2Xm086732@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         91943
>Category:       ports
>Synopsis:       [patch] misc/tinderbox shouldn't allow no database to be selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 18 09:50:02 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Vasil Dimov
>Release:        FreeBSD 6.0-STABLE amd64
>Organization:
DataMax
>Environment:

>Description:

As tinderbox is useless without a database the port should force (at
least) one to be selected in the `make config' step.

>How-To-Repeat:

>Fix:

--- tinderbox_db.diff begins here ---
Index: Makefile
===================================================================
RCS file: /usr/local/cvsupdroot/ports/misc/tinderbox/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	3 Jan 2006 00:00:47 -0000	1.5
+++ Makefile	18 Jan 2006 09:34:47 -0000
@@ -29,6 +29,10 @@
 
 .include <bsd.port.pre.mk>
 
+.if !defined(WITH_PGSQL) && !defined(WITH_MYSQL)
+BROKEN=	"Tinderbox is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL"
+.endif
+
 .if defined(WITH_PGSQL)
 USE_PGSQL=	yes
 USE_PHP+=	pgsql
--- tinderbox_db.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060118094505.GA1779>