From owner-svn-src-head@freebsd.org Sat Nov 9 12:55:08 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ED72C1A945C; Sat, 9 Nov 2019 12:55:08 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 479HDC6X35z3Dy7; Sat, 9 Nov 2019 12:55:07 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-ed1-f67.google.com with SMTP id b72so8231685edf.1; Sat, 09 Nov 2019 04:55:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JngLqI+BCOho9bx7N226LanVksiuFczUOT2A9807o4w=; b=Pqx+Y5Hordxk2MCum/vOiVfmz75ya+LA6mVTODmPIY5w3T0M3bo5ChhARKPGqTVFTd E6/Y0sZRsr+KzI3fUK6XFwlLZNmgPH3irfjOknA2GKzUWuw6+qHWCo/A9rlcZd+FF9MV P+t6ezA0AsRs33DruOPe3FsNA3oVb47H8G7NTbC4ySgspNo5UL55IYMDYKLwHRoHdOeV nOWHYhPo95+WPSdZs3c7emOuMDw5Ki78uqfRWRTg8Xcf3no4laf1NxVaA6fWdzWX/1/G ce9Es8K/qpM6a9sjDutnM57ifHKSbTczfoja3MkqUAXjsuRHP6GflGhbkaHNSVmRsOqr 087g== X-Gm-Message-State: APjAAAWR0JqQ2ecTjVcy6rgIWrG+bljhvaXnXNQtZarQnSvQ9jNwo1+s oQmfUa9i3Rx/k5Kp25yLlB89865ydbmNa2HFN3FBmMlzmT8= X-Google-Smtp-Source: APXvYqyHKfE/3+ZJmgL0nDMZu53s0hlf8nJOsGXw+7nEHBcbSONt1Cadrw08ln+TLgWK/Ocmrh2yZFrqEA++BqkATL0= X-Received: by 2002:a50:9fc1:: with SMTP id c59mr16283411edf.305.1573304105513; Sat, 09 Nov 2019 04:55:05 -0800 (PST) MIME-Version: 1.0 References: <201909132303.x8DN3uw3026373@repo.freebsd.org> <20191002220807.GA3971@spathi.chuq.com> In-Reply-To: <20191002220807.GA3971@spathi.chuq.com> From: Mariusz Zaborski Date: Sat, 9 Nov 2019 13:54:59 +0100 Message-ID: Subject: Re: svn commit: r352312 - in head: lib/geom/nop sys/geom/nop To: Chuck Silvers Cc: Alan Somers , svn-src-head , svn-src-all , src-committers , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 479HDC6X35z3Dy7 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of oshogbovx@gmail.com designates 209.85.208.67 as permitted sender) smtp.mailfrom=oshogbovx@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[67.208.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.99)[ip: (-4.68), ipnet: 209.85.128.0/17(-3.19), asn: 15169(-2.00), country: US(-0.05)]; FORGED_SENDER(0.30)[oshogbo@freebsd.org,oshogbovx@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[67.208.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[oshogbo@freebsd.org,oshogbovx@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Nov 2019 12:55:09 -0000 Hello Chuck :) I wonder if we shouldn't change this option a bit. Shouldn't we have an option which says more like: ``` Specifies the number of I/O requests to allow before setting the read and write failure rate. ``` In some cases, I don't want to have 100% of failure probabilities, but on the early stage, I would like to allow some read/writes requests. If the options would only specify the amount of the requests not the failure probabilities could be used in other cases? Those that make sens? Mariusz On Thu, 3 Oct 2019 at 00:08, Chuck Silvers wrote: > > On Wed, Oct 02, 2019 at 08:11:57AM -0600, Alan Somers wrote: > > On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers wrote: > > > > > Author: chs > > > Date: Fri Sep 13 23:03:56 2019 > > > New Revision: 352312 > > > URL: https://svnweb.freebsd.org/changeset/base/352312 > > > > > > Log: > > > Add a "count_until_fail" option to gnop, which says to start failing > > > I/O requests after the given number have been allowed though. > > > > > > Approved by: imp (mentor) > > > Reviewed by: rpokala kib 0mp mckusick > > > Sponsored by: Netflix > > > Differential Revision: https://reviews.freebsd.org/D21593 > > > > > > Modified: > > > head/lib/geom/nop/geom_nop.c > > > head/lib/geom/nop/gnop.8 > > > head/sys/geom/nop/g_nop.c > > > head/sys/geom/nop/g_nop.h > > > > > > > This patch introduces a backwards-compatibility bug. On a system with a > > post-352312 kernel but a pre-352312 userland, the gnop command will always > > fail with the error "gnop: Missing count_until_fail argument". > > -Alan > > Thanks for pointing this out, I'll see about fixing it right away. > > -Chuck > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"