From nobody Thu Jan 15 14:51:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsM2Lvgz6P4Ht for ; Thu, 15 Jan 2026 14:51:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsQsL6Ngqz3JRp for ; Thu, 15 Jan 2026 14:51:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qGypGlioopK9WmpJNLvnTPij5S/vBwPbHm5GkfeoG7c=; b=vkegjDFFlP8FCTzm25Np2FxiyM70o1sZMJMlR9vmVW+eZEMxhCiIjTrWNhyOs7UMe/PfTl /B5Ej7NGthHrJaz0bx3wDfKl7B0CDxJkve7qa7cA6aqG1JgFTZc+lBii9hK42mA+L0GLrO 7YutB3Syq8wnM5i5wbVrF/bgTvrCfIjWP9h3JN5r7b+lS3IP+f9qEfXcqiQ1qTKIi/gh9d CBkYAdHXfwmoN7LBqZUpG2Egs48OSadFRMGAcIQmhz/9Dnn6T2FMMKTh8CUpvu6qNE6Sp7 HC6yGqZ4XB/hKjSPrB8G9IXD3VlANXEHLsLu/C5Ia3TwhbreKFN1xdM5zsgHJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qGypGlioopK9WmpJNLvnTPij5S/vBwPbHm5GkfeoG7c=; b=NT1GO2yHRHwR0ouLqbaU3/sH5haQ+fED3HB6/LdaAyHbBeE5C7xQp0Zqi8EziP/ynxydaF 9Bgmovq+4PkzpKIjBTZjVERmr7+SS5LIvzzGtEFRGWWgWRa4XRUPkkkOq6qjaOQrx3B+6Y g8LKe7OpmImY/bIygGgO2OFsmkwpz9kWHFLsAV/JAlc9ZYvmKpPnhPdC7aJjwJbBJD7TCc 8VIlcoePYwacoO+1ylBTweD9s5yUEjuwV6yiPLHgOn8LMoumPiePEh42QhunMCZ7MO0Wez HhW9OujPLUYMHuWeMkeYwx8EbEhb/gdbjtHZVef2rRPYwRaLeiJtBqBrz6AoHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768488662; a=rsa-sha256; cv=none; b=S4np2IVImdqZAZI25mIgj031u4MOK0Bzbu3eBn4is6wfuCPMg85nRkAlWhEAYiSbx/GQWM kAhn7IuJwwDaw0YkiY08XjBAmNcTSsczbA98fQxdET8imxGjfItcs4bQWLnD3GLQ1CyVPp UXZdiHLi4Avqdxk3LWR8ZZ8VY/qbg+Iq9pDCIIRa2CXQbM2sZmWGEC/n9up/LUjSfKTaqt 8rZYIqrsvItHSTfvbqy21DYV4fmNs0oREuqs1Wwyv7rFMsT+hA1MZ48LmV00o/JwbSpuV/ 4Xdfbd7Fqg1ZGCrGXpOMKc3/wMc/wKTrvp+mxL5jwm3JGS+miLPj2s+7klMIOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsL5ndCzYsp for ; Thu, 15 Jan 2026 14:51:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23715 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Jan 2026 14:51:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrew Turner Subject: git: 68d8de27c94d - stable/14 - arm64: Fix enabling CPU features List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 68d8de27c94d585980a99e22fed60171bcaed2ef Auto-Submitted: auto-generated Date: Thu, 15 Jan 2026 14:51:02 +0000 Message-Id: <6968fed6.23715.502cfe06@gitrepo.freebsd.org> The branch stable/14 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=68d8de27c94d585980a99e22fed60171bcaed2ef commit 68d8de27c94d585980a99e22fed60171bcaed2ef Author: Andrew Turner AuthorDate: 2025-09-19 10:05:47 +0000 Commit: Andrew Turner CommitDate: 2026-01-14 21:14:13 +0000 arm64: Fix enabling CPU features Previously when enabling CPU feature we assumed the no check function means the feature was unconditionally enabled. When adding support to disable features on boot this check was incorrectly partially left in place. As all current features have a check function this meant all features were disabled. Fix this by restoring the previous behaviour while also allowing the user to disable the feature. Reviewed by: emaste Fixes: 4bc68fa98f68 ("arm64: Support managing features from loader") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52579 (cherry picked from commit 5e690f1e12ce8699f16019854dfffd1857a801d8) --- sys/arm64/arm64/cpu_feat.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/arm64/arm64/cpu_feat.c b/sys/arm64/arm64/cpu_feat.c index 986d5079e980..6aec0fdf8a78 100644 --- a/sys/arm64/arm64/cpu_feat.c +++ b/sys/arm64/arm64/cpu_feat.c @@ -63,10 +63,11 @@ enable_cpu_feat(uint32_t stage) PCPU_GET(cpuid) != 0) continue; - if (feat->feat_check != NULL) - continue; - - check_status = feat->feat_check(feat, midr); + if (feat->feat_check != NULL) { + check_status = feat->feat_check(feat, midr); + } else { + check_status = FEAT_DEFAULT_ENABLE; + } /* Ignore features that are not present */ if (check_status == FEAT_ALWAYS_DISABLE) continue;