From owner-cvs-src-old@FreeBSD.ORG Sat Feb 13 10:35:09 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1346D106573F for ; Sat, 13 Feb 2010 10:35:09 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9368F8FC0C for ; Sat, 13 Feb 2010 10:35:03 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o1DAZ34c003467 for ; Sat, 13 Feb 2010 10:35:03 GMT (envelope-from kib@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o1DAZ3rr003466 for cvs-src-old@freebsd.org; Sat, 13 Feb 2010 10:35:03 GMT (envelope-from kib@repoman.freebsd.org) Message-Id: <201002131035.o1DAZ3rr003466@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to kib@repoman.freebsd.org using -f From: Konstantin Belousov Date: Sat, 13 Feb 2010 10:34:50 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2010 10:35:09 -0000 kib 2010-02-13 10:34:50 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c Log: SVN rev 203818 on 2010-02-13 10:34:50Z by kib When ffs_realloccg() failed to allocate bigger fragment and, because pending blocks are scheduled for removal, goes to retry the (re)allocation, clear the bp pointer. It might happen that meantime free space is really exhausted and we are entering nospace: label without bread()ing buffer, causing stale bp value to be brelse()d again. Tested by: pho (Producing a scenario to reliably reproduce the race appeared to be much harder then fixing the bug) MFC after: 1 week Revision Changes Path 1.157 +3 -1 src/sys/ufs/ffs/ffs_alloc.c