Date: Sun, 12 Sep 2004 00:08:39 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: George Hartzell <hartzell@kestrel.alerce.com> Cc: freebsd-geom@FreeBSD.org Subject: Re: Mounting root... Message-ID: <20040911220839.GK30151@darkness.comp.waw.pl> In-Reply-To: <16707.28763.7201.383177@rosebud.alerce.com> References: <16706.33472.228042.851882@rosebud.alerce.com> <20040911074556.GI30151@darkness.comp.waw.pl> <16707.25008.865268.555842@rosebud.alerce.com> <16707.28763.7201.383177@rosebud.alerce.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Sep 11, 2004 at 02:38:35PM -0700, George Hartzell wrote:
+> George Hartzell writes:
+> > [...]
+> > Suggestions?
+>
+> Sorry to follow up my own posting, but I have something that works.
+>
+> Two changes to /etc/rc.d/swap1
+>
+> change stop_cmd from ':' to 'swap1_stop'
+>
+> and change the line in swap1_stop from
+>
+> swapctl -U -t blk
+>
+> to
+>
+> swapoff -a
+>
+> And 1 behavioural change. I reflexively use reboot to reboot the
+> machine, and hadn't ever made the connection that it doesn't run any
+> shutdown scripts. W/ the changes above, and using 'shutdown -r now'
+> to reboot the machine, it comes up w/out synching the mirror.
+>
+> COOL!
+>
+> To be consistent, one should probably also change the start_cmd to
+> swap1_start, and fix that function to use swapon -a since its usage of
+> swapctl is also broken. Then, no_swap and swapoff need to be
+> defaulted in /etc/defaults/rc.conf.
+>
+> Or, one could delete the swap1_{start,stop} functions, and just make
+> start_cmd be 'swapon -a' and stop_cmd be 'swapoff -a'.
+>
+> I don't know which is more better, clearly there's some history here
+> that's unfinished, or a cross-BSD compatibility thing, or???
+>
+> Pawel, should I file some kind of bug here, or should you do
+> something, or???
I already changed rc.d/swap1 locally, but before commiting it I want to
fix rc.d/addswap as well.
Speaking of rc.d/swap1. There is unused code from NetBSD and we don't
care about compatibility with their rcNG anymore, so it could be just
removed.
--
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFBQ3dnForvXbEpPzQRAt3cAKDAuIUnZsHEqVNVE2GHDO9U7GeItQCgqRUG
DKoCTWf9mI8ECWdrrrz6Q4c=
=t0zU
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040911220839.GK30151>