From owner-svn-src-head@freebsd.org  Sat Oct 27 13:40:52 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8752710863B9;
 Sat, 27 Oct 2018 13:40:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3F4436B1FD;
 Sat, 27 Oct 2018 13:40:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 2F7A1D994; Sat, 27 Oct 2018 13:40:52 +0000 (UTC)
Date: Sat, 27 Oct 2018 13:40:52 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Conrad Meyer <cem@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r339784 - head/sbin/dumpon
Message-ID: <20181027134052.GB40528@FreeBSD.org>
References: <201810261954.w9QJs05X054833@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201810261954.w9QJs05X054833@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2018 13:40:52 -0000

On Fri, Oct 26, 2018 at 07:54:00PM +0000, Conrad Meyer wrote:
> New Revision: 339784
> URL: https://svnweb.freebsd.org/changeset/base/339784
> 
> Log:
>   dumpon(8): Provide seatbelt against weak RSA keys
>   
> ...
> +#if OPENSSL_VERSION_NUMBER >= 0x10100000L
> +	if (RSA_security_bits(pubkey) < 112)
> +#else
> +	if (RSA_size(pubkey) * 8 < 2048)
> +#endif

Shouldn't the check be against 0x10100005L (that is, 1.1.0-pre5) to be
precise?

./danfe