From owner-cvs-all Sun Jan 27 15:43: 9 2002 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id B5EBF37B419; Sun, 27 Jan 2002 15:42:49 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 7358B7830B; Sun, 27 Jan 2002 14:53:56 +1030 (CST) Date: Sun, 27 Jan 2002 14:53:56 +1030 From: Greg Lehey To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumconfig.c vinumioctl.c Message-ID: <20020127145356.C41130@wantadilla.lemis.com> References: <200201270420.g0R4KrU26853@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201270420.g0R4KrU26853@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Saturday, 26 January 2002 at 20:20:53 -0800, Greg Lehey wrote: > grog 2002/01/26 20:20:53 PST > > Modified files: > sys/dev/vinum vinumconfig.c vinumioctl.c > Log: > vinumioctl: Fix a double fault caused by calling setjmp() without holding the config lock. The call was in fact superfluous. > > Revision Changes Path > 1.44 +3 -1 src/sys/dev/vinum/vinumconfig.c > 1.32 +0 -3 src/sys/dev/vinum/vinumioctl.c Grrr. Wrong text. Should be: vinumioctl: Fix a double fault caused by calling setjmp() without holding the config lock. The call was in fact superfluous. throw_rude_remark: Make sure we're holding the config lock before proceeding. There's no reason to assume that this has ever happened, but the alternative might be a double fault. Dump analysis by: Thomas Moestl MFC after: approval by re. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message