From owner-svn-ports-all@freebsd.org Tue Mar 16 21:57:48 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81D6656F6CD; Tue, 16 Mar 2021 21:57:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0Rwr3Cq9z3lf9; Tue, 16 Mar 2021 21:57:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 463E69EA3; Tue, 16 Mar 2021 21:57:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:42:0:2414:199b:8ec2:8376]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 39143942D80; Tue, 16 Mar 2021 21:57:46 +0000 (UTC) Date: Tue, 16 Mar 2021 22:57:44 +0100 From: Mathieu Arnold To: Adriaan de Groot Cc: Alexey Dokuchaev , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Message-ID: <20210316215744.jksqsyxsqm5254bb@aching.in.mat.cc> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org> <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fhbhxzlzowfyd2wr" Content-Disposition: inline In-Reply-To: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 21:57:48 -0000 --fhbhxzlzowfyd2wr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 16, 2021 at 08:59:29PM +0100, Adriaan de Groot wrote: > On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote: > > On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote: > > > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote: > > > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote: > > > > > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL} > > > > > + # Drop all leading spaces in the script, to minify > > > > > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL} > > > >=20 > > > > [[:space:]] works with all versions. > > >=20 > > > Yes please. Not just it's more robust, it also expresses the intenti= on > > > better, as we probably want to trim *any* unnecessary whitespace, not > > > some particular character. > >=20 > > So, anything prevents us from going the [[:blank:]] way? >=20 > So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to = prod=20 > at this right now. =46rom isspace(3) : =E2=80=9C\t=E2=80=9D =E2=80=9C\n=E2=80=9D =E2=80=9C\v=E2=80=9D =E2= =80=9C\f=E2=80=9D =E2=80=9C\r=E2=80=9D =E2=80=9C =E2=80=9D =66rom isblank(3) : =E2=80=9C\t=E2=80=9D =E2=80=9C =E2=80=9D --=20 Mathieu Arnold --fhbhxzlzowfyd2wr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmBRKdRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgIpdRAApNMGr4YlSsBtFALgAMu55ngKA5tMK9xADIX0kQoSmw+zmubtKPVDtwL5 IjwgbSHUz3jY7rIcqMcmehn1G8HzAxW+8R/DduZthQbda+H1Av86/nAa6SqY8UOm KXS7WqbQr6g8bDpxF3He3dBer8pIhNncDB82h6vXAKfCKQ0sVSh4CGMYndqt2PWv jwIA1GAyYo3D1Evlx3u+S/9rw9qWQKCzsWKa0qaPsPGpKZxleD74jeqx0xaa8a0P tVCDhiwkWVNuY2M1GPi1CTPtU+plb/x6CtTvTWNuNXEs7p0lxEU3/bdjuraItY2K 1/ih/VMhYfoBxJSF09xX/ona5slUBFC8qayFZ231cFJnlVGp8z6DSZcybSytrM++ o8pxJz0SO+381AKeH+GouBTk3ceDQxSgjfYtkoKg+8VQgYn8BN7jf+CCf4lnOUmH V+sX9xYRFOinZihiaNkoT7ijDUXlnrPd+xLEWe1h+RfTEhe3n94mxZ45DFzXbOkB 0LS4rFW6deefCSdNvSqYx2bHH8CeM4BjVa6hQSBk1V2P4zpg9xnbIY+UpHpNAY2q qEPzV/j4DwCDVVjLPvXRvP+5LZUIVImHquXsBZdM0V6yTttOnrSDUlNnNdHY2LZm CZ9FYNn9uiwGKAq+NagpLWyIDR0rO2B6v37DEqQ0ylz2C340O6A= =auDZ -----END PGP SIGNATURE----- --fhbhxzlzowfyd2wr--