From owner-freebsd-net@FreeBSD.ORG Tue Sep 8 14:21:42 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 935DF1065672 for ; Tue, 8 Sep 2009 14:21:42 +0000 (UTC) (envelope-from shteryana@gmail.com) Received: from mail-ew0-f208.google.com (mail-ew0-f208.google.com [209.85.219.208]) by mx1.freebsd.org (Postfix) with ESMTP id 2AFA78FC13 for ; Tue, 8 Sep 2009 14:21:41 +0000 (UTC) Received: by ewy4 with SMTP id 4so1702047ewy.36 for ; Tue, 08 Sep 2009 07:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=8Pr1UTRt6zxKvahBiaI/34tVs6DcNmxBsygssJausS4=; b=xYH62Jgq1A7Li4G8qdKARSt0WVx5Km9P/+caqUvvXW6su0/j69QAdlvfPc/x8QCp8Q IaP0iWJ+s6ZW6Jlu2C921MUGuQhlQDI3IMs3un/mItsQQSruYNsYM1SKPumFHE8fTUDE hcMSdw6t9JSiOdEpFqD0oQvkwCD0Ai+GWg3jw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=HVhCPPw4IgVBwjQiL6xuOXgSTDLT3nezKRSmE5TsZbvsfFHZuU8c5xtGtfSBbie+Ia QsB7Wfu6umuHW51doMjuT2YEcbUdl3CljPSXjiNElQdF4iXOY8tGb5HsYkKA65D9VpiB CqTxF4GNmVBVjBTtaW49pl6iI58ylPzO3rp9s= MIME-Version: 1.0 Received: by 10.211.173.14 with SMTP id a14mr3149610ebp.39.1252418092235; Tue, 08 Sep 2009 06:54:52 -0700 (PDT) In-Reply-To: <4AA65861.8@incunabulum.net> References: <4AA65663.8050106@incunabulum.net> <4AA65861.8@incunabulum.net> Date: Tue, 8 Sep 2009 16:54:52 +0300 Message-ID: <61b573980909080654x50670168x39001267ad81c6a3@mail.gmail.com> From: Shteryana Shopova To: Bruce Simpson Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-net@FreeBSD.org" , stef@memberwebs.com Subject: Re: Panic in imo_match_source (netinet/in_mcast.c) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 14:21:42 -0000 Hi, I actually managed to get the same kernel dump using the following sample code - http://people.freebsd.org/~syrinx/mcast/mcast_crash.c and the crash is 100% reproducable. A temporary fix is here - http://people.freebsd.org/~syrinx/mcast/in_mcast.c-20090908-01.diff but I actually prefer that we go over the logic in inp_join_group() again before proposing a patch for head as this is the second assert panic I am seeing it causes in the last few days. I can try making up a proper fix if Bruce is busy, but it will take a day or two until I'm able to fully test it. cheers, Shteryana On Tue, Sep 8, 2009 at 4:13 PM, Bruce Simpson wrote: > [Brief reply as I'm meant to be doing a zillion other things...] > > Bruce Simpson wrote: >> >> Full OS version, dmesg, panic and backtrace please, when reporting this >> kind of issue... otherwise folk can't help. Are you using SSM multicast >> features? > > P.S. You might want to try demoting the KASSERT to a conditional error > return (return no match if src is NULL or src->sa_family != AF_INET), and > see if that fix 'just works' for you. Sometimes the asserts I sprinkle into > code are too paranoid for what's going on, and syrinx@ recently caught one > of those. > > I can see some situations where this could kick off, so that is probably the > right fix. Please do let me know. If that fix works for you then it can > probably be checked in. There is an RC cutoff looming, so if I can't do it > in time, someone else may be able to check it in. > > thanks, > BMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >