From nobody Thu Nov 7 20:27:30 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xktsw5FQlz5cYDT for ; Thu, 07 Nov 2024 20:27:32 +0000 (UTC) (envelope-from shuriku@shurik.kiev.ua) Received: from mail.flex-it.com.ua (mail.flex-it.com.ua [193.239.74.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xktsw2kQ3z4sTN; Thu, 7 Nov 2024 20:27:32 +0000 (UTC) (envelope-from shuriku@shurik.kiev.ua) Authentication-Results: mx1.freebsd.org; none Received: from 93.183.208.50.ipv4.datagroup.ua ([93.183.208.50] helo=[192.168.200.135]) by mail.flex-it.com.ua with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.98 (FreeBSD)) (envelope-from ) id 1t996I-0000000094V-3Iyu; Thu, 07 Nov 2024 22:27:30 +0200 Message-ID: <21b5e9f7-b3c3-415a-b34a-e0a89215bc66@shurik.kiev.ua> Date: Thu, 7 Nov 2024 22:27:30 +0200 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: panic after a97f683fe3c425 To: Mark Johnston Cc: FreeBSD Current References: <95a67972-ea73-4821-bbec-3c8857b1f2f4@shurik.kiev.ua> Content-Language: uk-UA From: Oleksandr Kryvulia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ACL-Warn: SPF failed. 93.183.208.50 is not allowed to send mail from shurik.kiev.ua. X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:35297, ipnet:193.239.72.0/22, country:UA] X-Rspamd-Queue-Id: 4Xktsw2kQ3z4sTN X-Spamd-Bar: ---- 07.11.24 22:03, Mark Johnston: > On Thu, Nov 07, 2024 at 09:43:50PM +0200, Oleksandr Kryvulia wrote: >> Hi, @current >> >> My laptop now panics while boot with [1]. >> git bisect shows a97f683fe3c425b425cf8cc466319f54ea957c20 as offending >> commit. >> >> [1] https://imgur.com/a/Pb6eakW > I believe the patch below will fix the problem. > > diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c > index 77e0adda86f5..9569f8ace909 100644 > --- a/sys/amd64/vmm/vmm.c > +++ b/sys/amd64/vmm/vmm.c > @@ -513,8 +513,9 @@ static moduledata_t vmm_kmod = { > * > * - VT-x initialization requires smp_rendezvous() and therefore must happen > * after SMP is fully functional (after SI_SUB_SMP). > + * - vmm device initialization requires an initialized devfs. > */ > -DECLARE_MODULE(vmm, vmm_kmod, SI_SUB_SMP + 1, SI_ORDER_ANY); > +DECLARE_MODULE(vmm, vmm_kmod, MAX(SI_SUB_SMP, SI_SUB_DEVFS) + 1, SI_ORDER_ANY); > MODULE_VERSION(vmm, 1); > > static void > Yes, your patch solves a panic. Thank you!