From owner-freebsd-java@FreeBSD.ORG  Wed Sep 19 10:16:57 2007
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C011516A419;
	Wed, 19 Sep 2007 10:16:57 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx1.freebsd.org (Postfix) with ESMTP id 1948C13C46A;
	Wed, 19 Sep 2007 10:16:54 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <46F0F714.10608@FreeBSD.org>
Date: Wed, 19 Sep 2007 12:16:52 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: Kurt Miller <kurt@intricatesoftware.com>
References: <46EC1B55.4060202@FreeBSD.org>
	<200709180721.48995.kurt@intricatesoftware.com>
	<46F0243A.8020902@FreeBSD.org>
	<200709182213.00777.kurt@intricatesoftware.com>
In-Reply-To: <200709182213.00777.kurt@intricatesoftware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Daniel Eischen <deischen@freebsd.org>, Kip Macy <kip.macy@gmail.com>,
	performance@freebsd.org, freebsd-java@freebsd.org
Subject: Re: Massive performance loss from OS::sleep hack
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2007 10:16:57 -0000

Kurt Miller wrote:
> On Tuesday 18 September 2007 03:17:14 pm Kris Kennaway wrote:
>> Kurt Miller wrote:
>>> David Xu confirmed for me that pthread_yield() does give some
>>> time to lower priority threads on 7.0 using thr. Attached and inline
>>> are two patches for the 1.5 port that is how I suggest the issue be
>>> addressed.
>>>
>>> For 7.0 and up default UseThreadPriorities to true and always
>>> use pthread_yield(). For < 7.0 default UseThreadPriorities to
>>> false and conditionally use pthread_yield()/os_sleep(). User's
>>> can toggle UseThreadPriorities with the command line argument
>>> -XX:+UseThreadPriorities
>> Do we know that 6.x requires the old behaviour?  Maybe it can default to
>> on there too.  Otherwise this looks good to my eyeball (but the
>> DEFAULT_LD_LIBRARY_PATH change looks unrelated)
>>
>> -#define DEFAULT_LD_LIBRARY_PATH "/usr/lib" /* See ld.so.1(1) */
>> +#define DEFAULT_LD_LIBRARY_PATH "/usr/lib:/usr/local/lib" /* See
>> ld.so.1(1)
> 
> Yea I messed up the DEFAULT_LD_LIBRARY_PATH part. I didn't intend
> to change that segment of the existing os_bsd.cpp patch.
> 
> Regarding 6.x it either needs UseThreadPriorities defaulted to false
> or the os_sleep hack. After discussing the options with Daniel we
> agree that defaulting UseThreadPriorities to false and eliminating
> the os_sleep hack for all versions is the most consitant approach.
> 
> The following is a CVS diff of ports/java/jdk15 that updates the
> port to fix the performance issue plus an alternative method
> to setting DEFAULT_LD_LIBRARY_PATH without patching and
> substituting it:

This looks good to me, thanks!

Kris