From owner-freebsd-bugs Sat Aug 31 21:55:19 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E07A537B400; Sat, 31 Aug 2002 21:55:14 -0700 (PDT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC41A43E6E; Sat, 31 Aug 2002 21:55:13 -0700 (PDT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.5/8.12.5) with ESMTP id g814t6bq000670; Sun, 1 Sep 2002 08:55:07 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.5/8.12.5/Submit) id g814t6aw000669; Sun, 1 Sep 2002 08:55:06 +0400 (MSD) (envelope-from ache) Date: Sun, 1 Sep 2002 08:55:05 +0400 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= To: "."@babolo.ru Cc: David Malone , gpr@nvnpp.vrn.ru, freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG Subject: Re: bin/35812: strings(1) does'n print russian characters Message-ID: <20020901045505.GA560@nagual.pp.ru> References: <200208312250.g7VMod8H034002@freefall.freebsd.org> <200209010440.IAA02162@aaz.links.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200209010440.IAA02162@aaz.links.ru> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Sep 01, 2002 at 08:40:04 +0400, "."@babolo.ru wrote: > David Malone writes: > > Synopsis: strings(1) does'n print russian characters > > > > State-Changed-From-To: open->closed > > State-Changed-By: dwmalone > > State-Changed-When: Sat Aug 31 15:48:27 PDT 2002 > > State-Changed-Why: > > Submitter reckons PR can be closed (as a binutils issue at heart). > Without strings(1) patched? > I understand (may be) binutils issue, but > my patch bypass this issue. > (there was a little error in my previous patch) > > --- usr.bin/strings/strings.c Mon Apr 23 02:38:13 2001 > +++ usr.bin/strings/strings.c Wed Aug 22 05:05:04 2001 > @@ -170,7 +170,7 @@ > } > start: > for (cnt = 0; (ch = getch()) != EOF;) { > - if (ISSTR(ch)) { > + if (ISSTR(ch & 0xff)) { This patch: 1) Applies to source code not used for ELF binaries. 2) Not change anything there (ch is already without sign extension). -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message